Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GStreamer][MediaStream][Westeros] Enable 'immediate-output' on streaming through westerossink #16479

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[GStreamer][MediaStream][Westeros] Enable 'immediate-output' on streaming through westerossink #16479

merged 1 commit into from
Aug 9, 2023

Conversation

eocanha
Copy link
Contributor

@eocanha eocanha commented Aug 8, 2023 •
edited by webkit-early-warning-system
Loading

4861f4a

[GStreamer][MediaStream][Westeros] Enable 'immediate-output' on streaming through westerossink
https://bugs.webkit.org/show_bug.cgi?id=259930

Reviewed by Philippe Normand.

https://bugs.webkit.org/show_bug.cgi?id=259357 removed the configuration of the "immediate-output" property for westeros sink, but it's still needed for mediastream content.

Original author: Vivek.A <Vivek_Arumugam@comcast.com>
See: WebPlatformForEmbedded/WPEWebKit#1136

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::configureElementPlatformQuirks): Configure the immediate-output property for westerossink.

Canonical link: https://commits.webkit.org/266720@main

3caec37

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@eocanha eocanha requested a review from philn as a code owner August 8, 2023 16:08
@eocanha eocanha self-assigned this Aug 8, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 8, 2023 •
edited
Loading

EWS run on previous version of this PR (hash dd98fc2)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@eocanha eocanha added the Media Bugs related to the HTML 5 Media elements. label Aug 8, 2023
philn
philn requested changes Aug 8, 2023
View reviewed changes
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Outdated
@@ -2305,6 +2305,17 @@ void MediaPlayerPrivateGStreamer::configureElementPlatformQuirks(GstElement* ele
#endif
#endif

#if USE(WESTEROS_SINK)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this ifdef?

Copy link
Contributor Author

@eocanha eocanha Aug 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would mean one more runtime string comparison for all the other platforms with quirks, but the impact of that would be negligible.

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Outdated
#if ENABLE(MEDIA_STREAM)
if (m_streamPrivate && gstObjectHasProperty(element, "immediate-output")) {
GST_DEBUG_OBJECT(pipeline(), "Enable 'immediate-output' in WesterosSink");
g_object_set(G_OBJECT(element), "immediate-output", TRUE, nullptr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for G_OBJECT cast.

@eocanha eocanha mentioned this pull request Aug 8, 2023
Closed
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 8, 2023 •
edited
Loading

EWS run on current version of this PR (hash 3caec37)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@eocanha eocanha added the merge-queue Applied to send a pull request to merge-queue label Aug 9, 2023
@eocanha
[GStreamer][MediaStream][Westeros] Enable 'immediate-output' on strea…
4861f4a 
…ming through westerossink

https://bugs.webkit.org/show_bug.cgi?id=259930

Reviewed by Philippe Normand.

https://bugs.webkit.org/show_bug.cgi?id=259357 removed the configuration of the "immediate-output" property for westeros sink, but it's still needed for mediastream content.

Original author: Vivek.A <Vivek_Arumugam@comcast.com>
See: WebPlatformForEmbedded/WPEWebKit#1136

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::configureElementPlatformQuirks): Configure the immediate-output property for westerossink.

Canonical link: https://commits.webkit.org/266720@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266720@main (4861f4a): https://commits.webkit.org/266720@main

Reviewed commits have been landed. Closing PR #16479 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 9, 2023
@webkit-commit-queue webkit-commit-queue merged commit 4861f4a into WebKit:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philn philn philn approved these changes

Assignees

@eocanha eocanha

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eocanha @webkit-early-warning-system @webkit-commit-queue @philn