Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to set backend scale factor #44

Conversation

4 participants
@tokyovigilante
Copy link
Contributor

commented Apr 22, 2019

Allow clients to set a custom scale factor which is passed to the WPE backend. This enables HiDPI support on WPE platforms when combined with a WebKit patch.

@tokyovigilante tokyovigilante changed the base branch from master to libwpe-1.2 Apr 22, 2019

Show resolved Hide resolved include/wpe/view-backend.h Outdated
@aperezdc

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

I think we would rather have this merged in master instead of the cog-1.2 branch, because it needs changes which are not yet in any stable WPE WebKit release. AFAIK, GitHub does not allow changing the target branch after a PR has been created, but I can merge this by hand to master — other than that, the patch looks good to me taking into account @zdobersek's review comments.

@aperezdc aperezdc added the enhancement label May 6, 2019

Show resolved Hide resolved src/view-backend.c Outdated

@tokyovigilante tokyovigilante changed the base branch from libwpe-1.2 to master May 6, 2019

@tokyovigilante tokyovigilante force-pushed the tokyovigilante:hidpi-support branch from b196320 to d4151e0 May 6, 2019

@tokyovigilante tokyovigilante force-pushed the tokyovigilante:hidpi-support branch from d4151e0 to 02c357e May 6, 2019

@tokyovigilante

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

Changes made, thanks.

@aperezdc

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

I have manually resolved the conflicts, and this is now merged in master as commit 4b9fd32 — thanks a lot @tokyovigilante!

@tokyovigilante

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

No problem, thank you! Will try and get the WebKit side in and send in the Cog changes required too.

@tokyovigilante tokyovigilante deleted the tokyovigilante:hidpi-support branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.