Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to set backend scale factor #44

Closed
wants to merge 1 commit into from
Closed

Add function to set backend scale factor #44

wants to merge 1 commit into from

Conversation

tokyovigilante
Copy link
Contributor

@tokyovigilante tokyovigilante commented Apr 22, 2019 •
edited
Loading

Allow clients to set a custom scale factor which is passed to the WPE backend. This enables HiDPI support on WPE platforms when combined with a WebKit patch.

@tokyovigilante tokyovigilante changed the base branch from master to libwpe-1.2 April 22, 2019 12:04
@aperezdc
Copy link
Contributor

aperezdc commented May 6, 2019

I think we would rather have this merged in master instead of the cog-1.2 branch, because it needs changes which are not yet in any stable WPE WebKit release. AFAIK, GitHub does not allow changing the target branch after a PR has been created, but I can merge this by hand to master — other than that, the patch looks good to me taking into account @zdobersek's review comments.

carlosgcampos
carlosgcampos reviewed May 6, 2019
View reviewed changes
src/view-backend.c Outdated Show resolved Hide resolved
@tokyovigilante tokyovigilante changed the base branch from libwpe-1.2 to master May 6, 2019 09:39
@tokyovigilante
Copy link
Contributor Author

Changes made, thanks.

@aperezdc
Copy link
Contributor

aperezdc commented May 8, 2019

I have manually resolved the conflicts, and this is now merged in master as commit 4b9fd32 — thanks a lot @tokyovigilante!

@aperezdc aperezdc closed this May 8, 2019
@aperezdc aperezdc mentioned this pull request May 8, 2019
Closed
@tokyovigilante
Copy link
Contributor Author

No problem, thank you! Will try and get the WebKit side in and send in the Cog changes required too.

@tokyovigilante tokyovigilante deleted the hidpi-support branch May 9, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgcampos carlosgcampos carlosgcampos left review comments

@zdobersek zdobersek zdobersek approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tokyovigilante @aperezdc @zdobersek @carlosgcampos