Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdo/wayland: Blurry rendering on HiDPI displays #16

Closed
aperezdc opened this issue May 18, 2018 · 6 comments · Fixed by #94
Closed

fdo/wayland: Blurry rendering on HiDPI displays #16

aperezdc opened this issue May 18, 2018 · 6 comments · Fixed by #94
Assignees
Labels
bug Something isn't working upstream Needs support from an upstream

Comments

@aperezdc
Copy link
Member

For comparison, Cog on the left and Epiphany (which uses WebKitGTK+) on the right:

webkit-wpe-gtk-hidpi-comparison

@aperezdc aperezdc added bug Something isn't working help wanted Extra attention is needed labels May 18, 2018
@aperezdc
Copy link
Member Author

For example in this commit in MPV there is some handling of the scaling reported by the Wayland compositor to make sure things are rendered properly. I suspect WPE WebKit (or the WPE FDO backend) are missing something like that, so I have filed an issue upstream:

Let's keep this one open in case we need to add some support code in Cog's FDO platform plug-in as well.

@aperezdc aperezdc added the upstream Needs support from an upstream label Mar 28, 2019
@aperezdc
Copy link
Member Author

aperezdc commented May 8, 2019

This will a version of libwpe which includes WebPlatformForEmbedded/libwpe#44 and some support code in cog-platform-fdo.c to inform WPE WebKit about the device scaling factor reported by Wayland.

@aperezdc aperezdc removed the help wanted Extra attention is needed label May 8, 2019
@aperezdc aperezdc self-assigned this May 8, 2019
tokyovigilante added a commit to tokyovigilante/cog that referenced this issue May 12, 2019
Enables Wayland HiDPI support. Also scale pointer
events by scale factor to match display. Closes Igalia#16.
tokyovigilante added a commit to tokyovigilante/cog that referenced this issue May 12, 2019
Enables Wayland HiDPI support. Also scale pointer
events by scale factor to match display. Closes Igalia#16.
tokyovigilante added a commit to tokyovigilante/cog that referenced this issue May 13, 2019
Enables Wayland HiDPI support. Also scale pointer
events by scale factor to match display. Closes Igalia#16.
@tokyovigilante
Copy link
Contributor

WebKit HiDPI patch landed at r245394.

@aperezdc
Copy link
Member Author

I have just reviewed #94 (sorry about the delay), and I must say that @tokyovigilante has been doing a terrific contribution here, touching all the needed parts in the different components (libwpe, WebKit, etc). Kudos to him 🏅

@tokyovigilante
Copy link
Contributor

Thanks for the review! No issues with any of your feedback, will get an updated PR pushed in the next day or so.

tokyovigilante added a commit to tokyovigilante/cog that referenced this issue May 29, 2019
Enables Wayland HiDPI support. Also scale pointer
events by scale factor to match display. Closes Igalia#16.
@tokyovigilante
Copy link
Contributor

Ok, 300b48d should hopefully do it. I've also fleshed out registry_global_remove to deregister an output if it's removed from the system (ie monitor hotplug). Let me know if there are any more style issues, I commit here and there to a few projects and I do miss the odd convention, sorry!

tokyovigilante added a commit to tokyovigilante/cog that referenced this issue May 31, 2019
Enables Wayland HiDPI support. Also scale pointer
events by scale factor to match display. Closes Igalia#16.
aperezdc pushed a commit that referenced this issue Jun 3, 2019
Enables Wayland HiDPI support. Also scale pointer
events by scale factor to match display. Closes #16.
bykov34 pushed a commit to bykov34/cog that referenced this issue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Needs support from an upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants