Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all tags to html class map to support all derived tag type through createElement API #248

Closed
wants to merge 1 commit into from

Conversation

Havunen
Copy link
Contributor

@Havunen Havunen commented Nov 1, 2023

Fixes #245

@WebReflection
Copy link
Owner

ehm ... no ... if you read the how to contribute the classes you see are placeholders.

If no special meaning or type is needed, this is not going to happen because it's crytical on the performance path.

If you ned to check instanceof it means you are using LinkeDOM for testing purpose and I am tired to state this is not the goal of the library so while I really do appreciate your will to contribute, this is not what this library needs + I think your PR is not doing what you think it's doing.

Special elements pollute the parsing and bootstrap all over the place ... anything that behaves like a div is good enough by being just an Element ... everything else, unless really needed, doesn't need to be a special case.

Select and a few others are examples you can see how these get registered, other classes are here to simplify augmenting their presence and nature on the dom, not to have 1:1 instanceof operations.

I am afraid this is not landing as it is.

@WebReflection
Copy link
Owner

a better answer in here: #247 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] document.createElement() API should create matching derived type of html element
2 participants