Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCAYT leaves underlined word after CKEditor replace dialog corrects it. #148

Closed
jswiderski opened this issue Aug 3, 2017 · 3 comments
Closed
Assignees
Milestone

Comments

@jswiderski
Copy link

We had this issue reported before https://dev.ckeditor.com/ticket/5700 but it seems it has come back.

To reproduce:

  1. Clear editor content and stype few misspelled words.
  2. Enable SCAYT
  3. Open replace dialog and find/replace incorrect word with correct one.
    Result: correct word stays underlined.

I have also tried firing change event in this line https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/find/dialogs/find.js#L506 hoping that it will solve the problem but that didn't help. You guys most likely don't use that editor event.

If some other event, that you need, should be fired here, please let us know.

@jalners
Copy link
Member

jalners commented Aug 4, 2017

Let us investigate this issue as this fix was done a while ago (7 years ago). As soon as we have any results, we will provide you with ETA for the fix.

jalners added a commit that referenced this issue Aug 4, 2017
@jalners
Copy link
Member

jalners commented Aug 4, 2017

@jshaptala
Copy link
Member

Please be informed that the fix has already been included in our release 4.9.2.

@jshaptala jshaptala assigned jshaptala and jalners and unassigned jshaptala Aug 8, 2017
@jshaptala jshaptala added this to the 4.9.2 milestone Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants