Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CKEDITOR.getUrl when referencing style sheets #166

Open
glen-84 opened this Issue Mar 4, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@glen-84
Copy link

glen-84 commented Mar 4, 2019

scayt.css and dialog.css are referenced without using CKEDITOR.getUrl.

I can send a PR, but it'll probably be a lot faster for you to just make the changes yourself (2 lines).

See also:

@wsc-julia-shaptala

This comment has been minimized.

Copy link
Member

wsc-julia-shaptala commented Mar 6, 2019

Hi @glen-84, thank you for your suggestion. We have added this improvement to our product backlog. We will add this fix in scope of other changes that will be required for this plugin. The procedure of the plugins updates depends on CKEditor's releases as well. Even if we make the change, this change must be included by CKEditor as a part of their release. As for now we do not have ETA for the update from our side. But we will keep you posted.

@wsc-julia-shaptala wsc-julia-shaptala added this to the 5.4.0 milestone Mar 13, 2019

@wsc-julia-shaptala

This comment has been minimized.

Copy link
Member

wsc-julia-shaptala commented Mar 13, 2019

@glen-84, we will add this small enhancement as a part of our next release 5.4.0. ETA: end of March, beginning of April 2019.

@artem-abakumov

This comment has been minimized.

Copy link
Member

artem-abakumov commented Apr 3, 2019

@glen-84 5.4.0 was released. Enhancement was included.

@artem-abakumov

This comment has been minimized.

Copy link
Member

artem-abakumov commented Apr 3, 2019

@glen-84 Please note that change will be included to the next minor CKEditor release.

But if you want it ASAP you can build CKEditor with or latest plugin using next manual:

Checkout CKEditor 4+ from github.com

  1. Create folder: ‘ckeditor’
  2. Open Git Bash
  3. In Git Bash: go to ‘ckeditor’ local folder: cd ../ckeditor
  4. Perform for testing purpose: git clone https://github.com/ckeditor/ckeditor-dev.git
  5. Perform for delivery purpose:
    git clone https://github.com/ckeditor/ckeditor-dev.git
    git checkout tags/number_of_tag
  6. Add SCAYT and WSC plugins
  7. Go to checked out local folder:
    cd ../ckeditor/ckeditor-dev/plugins

Clone scayt and wsc plugins

  1. Clone scayt and wsc plugins
    git clone https://github.com/WebSpellChecker/ckeditor-plugin-scayt.git scayt
    git clone https://github.com/WebSpellChecker/ckeditor-plugin-wsc.git wsc
    (if you need clone not a master branch, you need to use next command in GitBush:
  2. git clone -b another_branch https://github.com/WebSpellChecker/ckeditor-plugin-scayt.git )
  3. Go to checked out local folder: cd ../ckeditor/ckeditor-dev
  4. Update config.js file with: 'scayt,' + and 'wsc,' + before selectall and wysiwygarea correspondingly

Build CKEditor 4

  1. Go to builder folder: cd ../ckeditor/ckeditor-dev/dev/builder/
  2. Update …/dev/builder/build-config.js file with: scayt: 1, and wsc: 1, before selectall and wysiwygarea correspondingly
  3. cd ../ckeditor/ckeditor-dev/dev/builder using GitBush
  4. Build CKEditor 4: sh build.sh using GitBush
  5. Builded CKEditor 4 is located in ‘release’ folder
@glen-84

This comment has been minimized.

Copy link
Author

glen-84 commented Apr 3, 2019

Thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.