Removing "dir" attribute from body is wrong, and causes bugs #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused bugs in fullPage edit mode, where the user can't save a custom dir attribute! This bug has been around since 2012
WebSpellChecker
pushed a commit
that referenced
this pull request
Dec 18, 2014
|
We confirm the issue. The fix is ready and pushed into 'scayt-dev' branch. |
|
We're glad to inform you that the fix is committed into master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused bugs in fullPage edit mode, where the user can't save a custom dir attribute!
This bug has been around since 2012