Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-upgrade script #814

Merged
merged 3 commits into from
Mar 30, 2018
Merged

Conversation

hobinjk
Copy link
Contributor

@hobinjk hobinjk commented Mar 29, 2018

Fix #632. Progresses forward on #641 but the zwave issue needs
consideration.

Fix WebThingsIO#632. Progresses forward on WebThingsIO#641 but the zwave issue needs
consideration.
@ghost ghost assigned hobinjk Mar 29, 2018
@ghost ghost added the review label Mar 29, 2018
@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #814 into master will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   77.74%   77.11%   -0.64%     
==========================================
  Files          87       87              
  Lines        3721     3762      +41     
  Branches      497      501       +4     
==========================================
+ Hits         2893     2901       +8     
- Misses        760      789      +29     
- Partials       68       72       +4
Impacted Files Coverage Δ
src/controllers/new_things_controller.js 43.75% <0%> (-31.25%) ⬇️
src/controllers/things_controller.js 82.8% <0%> (-10.49%) ⬇️
src/addon-manager.js 62.06% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18b551...80fce4b. Read the comment docs.

@mrstegeman
Copy link
Contributor

mrstegeman commented Mar 30, 2018

@hobinjk Could you add the following to post-upgrade.sh, please?

# Upgrade gateway-addon Python package
_url="git+https://github.com/mozilla-iot/gateway-addon-python#egg=gateway_addon"
sudo pip2 install -U "$_url"
sudo pip3 install -U "$_url"

@mrstegeman mrstegeman self-requested a review March 30, 2018 13:19
@hobinjk
Copy link
Contributor Author

hobinjk commented Mar 30, 2018

@mrstegeman Updated accordingly

@mrstegeman
Copy link
Contributor

Thanks! Are we worried about this messing things up if the update is rolled back?

@hobinjk
Copy link
Contributor Author

hobinjk commented Mar 30, 2018

The node update will cause issues if the update fails. This can be resolved if we want to create an 0.3.2 release with nvm alias default v7.10.1 in upgrade-rollback.sh. I'm not sure if we are that concerned at this stage but we should attempt to limit this script to backwards-compatible changes in the future.

@hobinjk
Copy link
Contributor Author

hobinjk commented Mar 30, 2018

Oh wait, the rollback script used is actually this one. I'll update accordingly

@hobinjk hobinjk merged commit 895e238 into WebThingsIO:master Mar 30, 2018
@ghost ghost removed the review label Mar 30, 2018
@hobinjk hobinjk deleted the post-upgrade-script branch March 30, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants