Move add-on version into each package definition. #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hobinjk
reviewed
Apr 6, 2018
| @@ -409,7 +409,8 @@ const SettingsScreen = { | |||
| let updateUrl = null, updateVersion = null, updateChecksum = null; | |||
| if (this.availableAddons.has(name)) { | |||
| const available = this.availableAddons.get(name); | |||
| if (available.version !== addon.version) { | |||
| const cmp = this.compareSemver(addon.version, available.version); | |||
There was a problem hiding this comment.
The compareSemver function can be replaced with semver.compare
Oh nevermind, I see, disregard this
There was a problem hiding this comment.
Not on the UI side...
hobinjk
approved these changes
Apr 6, 2018
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
==========================================
+ Coverage 77.09% 77.16% +0.06%
==========================================
Files 87 87
Lines 3768 3766 -2
Branches 503 502 -1
==========================================
+ Hits 2905 2906 +1
+ Misses 790 787 -3
Partials 73 73
Continue to review full report at Codecov.
|
|
Depends on WebThingsIO/addon-list#47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.