Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close file descriptors in hashFile function #864

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

dhylands
Copy link
Contributor

No description provided.

@dhylands dhylands self-assigned this Apr 10, 2018
@ghost ghost added the review label Apr 10, 2018
@codecov-io
Copy link

Codecov Report

Merging #864 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
- Coverage   77.09%   77.08%   -0.01%     
==========================================
  Files          87       87              
  Lines        3772     3775       +3     
  Branches      502      503       +1     
==========================================
+ Hits         2908     2910       +2     
- Misses        791      792       +1     
  Partials       73       73
Impacted Files Coverage Δ
src/utils.js 81.81% <75%> (-2.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a9c48...350964b. Read the comment docs.

Copy link
Contributor

@mrstegeman mrstegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@dhylands dhylands merged commit e31da18 into WebThingsIO:master Apr 10, 2018
@ghost ghost removed the review label Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants