Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Capability - closes #11 #58

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Conversation

benfrancis
Copy link
Member

Lock capability with LockedProperty and TargetLockedProperty.

Notes:

  • I made TargetLockedProperty a string enum rather than a boolean to be consistent with LockedProperty but also because I can imagine feasibly adding other states later (e.g. "doublelocked")
  • I haven't added a property to store key codes. Partly because we don't yet support object properties, but also partly because I think it might require some more thought, e.g. around whether you actually want to send key codes in plain text over the Internet, and what's the best way to set and store them. We can extend the schema with this later, or potentially create a separate key pad schema of some kind.

Question:

  • Should TargetLockedProperty be required or not? Might there be a need for a read-only lock which you can read the state of but not actuate? We'd need to figure out how you would represent that in a UI.

Copy link
Contributor

@mrstegeman mrstegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the one typo. Nice and simple.

index.html Outdated
</tr>
<tr>
<th>enum</th>
<td>["locked", "unlocked", "uknown", "jammed"]</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "uknown"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants