Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest-2022 Contributors page #203

Merged
merged 8 commits into from
Oct 4, 2022
Merged

Hacktoberfest-2022 Contributors page #203

merged 8 commits into from
Oct 4, 2022

Conversation

Anuran12
Copy link
Member

@Anuran12 Anuran12 commented Oct 1, 2022 •
edited by gitpod-io bot
Loading

Related Issue

  • Information about the related issue

Closes: #193

Describe the changes you've made

I added contribution page. I use external CSS file "contributers.module.css" for styling the page. I added "contributors" button in the navbar

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

I created a local hosting to test the changes . I tested for various screen ratio to check the responsive

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot

image

Code of Conduct

gptkrsh
gptkrsh suggested changes Oct 1, 2022
View reviewed changes
Copy link

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI seems to fail, I have rerun it because I don't seem to find any issues 🤔 But there are some other suggestions that I think should be implemented

src/pages/contributors.js
import styles from '../styles/contributors.module.css';

export const getStaticProps = async () => {
const res = await fetch('https://api.github.com/repos/WebXDAO/webXDAO.github.io/contributors');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can filter out the time using GitHub's graphql API, can you take a look into that?

This will also fix the fact that this is only checking for the repo, not the whole org

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why I need to add graphql ? this is working perfectly... : )

and @mkubdev told me to use the api and fetch the data like this. That's why I did like this

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine using the current method unless there are any differences/improvements using GitHub's GraphQL API.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what should I do now ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Panquesito7 this will only calculate the contributors of this repo not the org, also it will have all contributors not hacktoberfest contributors

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krshkun Hi, yeah the task was to show only contributors from this repos. We can enhance the display with a graphql implementation later in a future feature request! (You can open it!)

src/pages/contributors.js Outdated Show resolved Hide resolved
src/styles/contributors.module.css Outdated Show resolved Hide resolved
@vinzvinci vinzvinci requested a review from mkubdev October 1, 2022 12:29
@Anuran12 Anuran12 requested review from gptkrsh and removed request for mkubdev October 1, 2022 17:30
@Anuran12
Copy link
Member Author

Anuran12 commented Oct 1, 2022

The CI seems to fail, I have rerun it because I don't seem to find any issues 🤔 But there are some other suggestions that I think should be implemented

@krshkodes Hey now the CI does not fail anymore... can you please re-review this and tell me what should I do now ?

@gptkrsh
Copy link

gptkrsh commented Oct 1, 2022

@Anuran12
#203 (comment)

@Panquesito7 Panquesito7 added the enhancement New feature or request label Oct 2, 2022
@mkubdev
Copy link
Contributor

mkubdev commented Oct 4, 2022 •
edited
Loading

I close since #210 solve the issue. Oops!

@mkubdev mkubdev closed this Oct 4, 2022
@mkubdev
Copy link
Contributor

mkubdev commented Oct 4, 2022

Sorry, misread the linked issue.

@mkubdev mkubdev reopened this Oct 4, 2022
mkubdev
mkubdev approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@mkubdev mkubdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good to me 🚀

@vinzvinci vinzvinci added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 4, 2022
vinzvinci
vinzvinci approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!

@vinzvinci vinzvinci merged commit b8b255c into WebXDAO:main Oct 4, 2022
@Anuran12
Copy link
Member Author

Anuran12 commented Oct 4, 2022

Thanks for your contributions!

Thanks 😊
thanks all @mkubdev @vinzvinci this was my first open source contribution . feeling happy.

Hey but @krshkun said me to use github graphql api to fetch all contributors data of this organization not only this repo.
and i started working on this.

so maybe I will make another issue and PR for this .

okay ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkubdev mkubdev mkubdev approved these changes

@Panquesito7 Panquesito7 Panquesito7 left review comments

@shuklaritvik06 shuklaritvik06 shuklaritvik06 approved these changes

@vinzvinci vinzvinci vinzvinci approved these changes

@gptkrsh gptkrsh Awaiting requested review from gptkrsh

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add contributors page
6 participants
@Anuran12 @gptkrsh @mkubdev @Panquesito7 @shuklaritvik06 @vinzvinci