-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default value for houseNumber. #24
Conversation
Change street parameter naming to match sendcloud API naming
@lukas-jansen Thanks for the contribution! I've looked through it and played around with it for a bit. I'm going to add some changes to address some concerns before this can be merged:
|
@villermen The street and housenumber can still be obtained separately https://github.com/Webador/sendcloud/pull/24/files#diff-0776c3ed4485bbdfe0e342af8a73172d8fe7c73ec79d485a529929c425a268b3L12-L13 Sendcloud will still return the address divided parameters with the street and housenumber it parsed from the address |
@lukas-jansen You're right! I meant to say I want to support both situations without having to do add or split the addresses ourselves. Like so: 1bb4910#diff-0776c3ed4485bbdfe0e342af8a73172d8fe7c73ec79d485a529929c425a268b3R7-R29 Question on the side: I know the API calls it "address", but we already call our model that way. Do you reckon calling the property "addressLine1" would make things more clear or more confusing? |
In our case (Craft CMS) is using this package for addressing, what follows the https://github.com/commerceguys/addressing |
@lukas-jansen Thanks for the solution and thinking with me on this! I'll push a major release that includes these changes shortly. |
Changed street parameter naming to match sendcloud API naming
Closes #23