Add auto translation as "approved" (Closes: #9048) (#9174)

* Add auto translation as "approved" (Closes: 9048)

* Only show approved choice if user has the permission

* fixup! Only show approved choice if user has the permission

weblate/api/views.py

@@ -1143,7 +1143,7 @@ def autotranslate(self, request, **kwargs):
         if translation.component.locked:
             self.permission_denied(request, "Component is locked")
 
-        autoform = AutoForm(translation.component, request.data)
+        autoform = AutoForm(translation.component, request.user, request.data)
         if not autoform.is_valid():
             errors = {}
             for field in autoform:

weblate/trans/autotranslate.py

@@ -12,7 +12,7 @@
 from weblate.machinery.models import MACHINERY
 from weblate.trans.models import Change, Component, Suggestion, Unit
 from weblate.trans.util import split_plural
-from weblate.utils.state import STATE_FUZZY, STATE_TRANSLATED
+from weblate.utils.state import STATE_APPROVED, STATE_FUZZY, STATE_TRANSLATED
 
 
 class AutoTranslate:
@@ -31,7 +31,11 @@ def __init__(
         self.mode = mode
         self.updated = 0
         self.progress_steps = 0
-        self.target_state = STATE_FUZZY if mode == "fuzzy" else STATE_TRANSLATED
+        self.target_state = STATE_TRANSLATED
+        if mode == "fuzzy":
+            self.target_state = STATE_FUZZY
+        elif mode == "approved":
+            self.target_state = STATE_APPROVED
         self.component_wide = component_wide
 
     def get_units(self, filter_mode=True):

weblate/trans/forms.py

@@ -869,11 +869,6 @@ class AutoForm(forms.Form):
 
     mode = forms.ChoiceField(
         label=_("Automatic translation mode"),
-        choices=[
-            ("suggest", _("Add as suggestion")),
-            ("translate", _("Add as translation")),
-            ("fuzzy", _('Add as "Needing edit"')),
-        ],
         initial="suggest",
     )
     filter_type = FilterField(
@@ -908,7 +903,7 @@ class AutoForm(forms.Form):
         label=_("Score threshold"), initial=80, min_value=1, max_value=100
     )
 
-    def __init__(self, obj, *args, **kwargs):
+    def __init__(self, obj, user=None, *args, **kwargs):
         """Generate choices for other components in the same project."""
         super().__init__(*args, **kwargs)
         self.obj = obj
@@ -969,6 +964,15 @@ def __init__(self, obj, *args, **kwargs):
             x for x in self.fields["filter_type"].choices if x[0] in use_types
         ]
 
+        choices = [
+            ("suggest", _("Add as suggestion")),
+            ("translate", _("Add as translation")),
+            ("fuzzy", _('Add as "Needing edit"')),
+        ]
+        if user is not None and user.has_perm("unit.review", obj):
+            choices.append(("approved", _("Add as approved translation")))
+        self.fields["mode"].choices = choices
+
         self.helper = FormHelper(self)
         self.helper.layout = Layout(
             Field("mode"),

weblate/trans/tests/test_autotranslate.py

@@ -19,6 +19,8 @@ def setUp(self):
         # Need extra power
         self.user.is_superuser = True
         self.user.save()
+        self.project.translation_review = True
+        self.project.save()
         self.component2 = Component.objects.create(
             name="Test 2",
             slug="test-2",
@@ -83,6 +85,11 @@ def test_suggest(self):
         self.perform_auto(mode="suggest")
         self.perform_auto(0, 1, mode="suggest")
 
+    def test_approved(self):
+        """Test for automatic suggestion."""
+        self.perform_auto(mode="approved")
+        self.perform_auto(0, 1, mode="approved")
+
     def test_inconsistent(self):
         self.perform_auto(0, filter_type="check:inconsistent")
 

weblate/trans/views/basic.py

@@ -346,7 +346,12 @@ def show_translation(request, project, component, lang):
             "form": form,
             "download_form": DownloadForm(obj, auto_id="id_dl_%s"),
             "autoform": optional_form(
-                AutoForm, user, "translation.auto", obj, obj=component
+                AutoForm,
+                user,
+                "translation.auto",
+                obj,
+                obj=component,
+                user=user,
             ),
             "search_form": search_form,
             "replace_form": optional_form(ReplaceForm, user, "unit.edit", obj),

weblate/trans/views/edit.py

@@ -714,7 +714,7 @@ def auto_translation(request, project, component, lang):
     if not request.user.has_perm("translation.auto", project):
         raise PermissionDenied
 
-    autoform = AutoForm(translation.component, request.POST)
+    autoform = AutoForm(translation.component, request.user, request.POST)
 
     if translation.component.locked or not autoform.is_valid():
         messages.error(request, _("Failed to process form!"))