Automatic translation support adding translation as "approved"

[KadAnna]

Describe the problem

Following ticket #8979, I would like to have an option to set the automatically translated strings as "for review". This will correspond with the "for review" workflow.

Describe the solution you'd like

Add an option "Add as for review" to Automatic translation mode of the add-on set-up.

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

No response

[nijel]

The strings should be added as “for review” right now. I thought you wanted to have the possibility to add strings as “approved”.

[github-actions]

This issue has been added to the backlog. It is not scheduled on the Weblate roadmap, but it eventually might be implemented.

In case you need this feature soon, please consider helping or push it by funding the development.

[KadAnna]

I just tried tool Automatic translation. There the Automatic translation mode Add as translation (together with Enabled reviews Setting) sets strings as for review. So it this is the same at the addon Automatic translation, then this ticket is unnecessary. Just that because of the bug #8979 I could not see it.

[nijel]

I still think it makes sense to add an option to add string as approved, so let's keep this issue open.

[nijel]

To implement this:

• AutoForm needs to extend __init__ so that it adds Add as approved when reviews are enabled:

  weblate/weblate/trans/forms.py

  Line 906 in 18f8542

  def __init__(self, obj, *args, **kwargs):

• AutoTranslate needs support for mode = approved, at leas here:

  weblate/weblate/trans/autotranslate.py

  Line 34 in 18f8542

  self.target_state = STATE_FUZZY if mode == "fuzzy" else STATE_TRANSLATED

[github-actions]

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

[Krishhhnaa]

is this issue closed ?

[nijel]

No, it is open.

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.