"strings needing action" doesn't actually count all strings needing action

[matejcik]

Notably, the number does not include strings that are translated but have failing checks.

Also, for our purposes, we need to count strings with suggestions as "for review"; this will probably change if we implement a proper review workflow.

I propose counting strings with failing checks into "strings needing action".

Suggestions (and possibly comments) are trickier: the checklist item doesn't differentiate between untranslated and translated, which makes it impossible to get an exact number and wordcount of "strings needing work" for people who need or want that. OTOH, counting them in "strings needing action" would annoy people who don't care about suggestions on already translated strings.

At this point, i'm thinking of implementing a "Clean strings" checklist item, in addition to "Translated strings", and possibly a corresponding "Dirty strings" which is total - clean

[dg0yt]

Not all strings with failing checks are needing action. Sometimes a particular translation is failing a check and still valid, e.g.

• unchanged translation: "Magenta" can have a unchanged translation in some langages.
• final punctuation: The source string ends in "!" but the translation is to use "." (maybe with a request to change the source string).

In these cases it would be helpful to add a flag just for particular languages (maybe something like 'ignore-same:de,fr'). But I guess this should be raised as another issue.

[matejcik]

isn't there an option to clear the failing checks for such purposes?

[dg0yt]

I don't know what you mean by "clear". I know that I can set flags on the source string. These flags apply to all languages which is not always what I want (cf. my previous comment).

[nijel]

You can ignore the specific failing check by clicking on the X at the check, there is even keyboard shortcut for that - Alt+I and then the shown digit:

[comradekingu]

Ignored checks is an action needed, with possible further action needed in source.

The "needs editing" checkbox should always be available for source language too, so that the "needs editing" for any component language only tracks the component language browsed.

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.