Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weblate uses the wrong format when creating new XWiki files #11879

Closed
2 tasks done
surli opened this issue Jun 17, 2024 · 2 comments · Fixed by #11880
Closed
2 tasks done

Weblate uses the wrong format when creating new XWiki files #11879

surli opened this issue Jun 17, 2024 · 2 comments · Fixed by #11880
Assignees
Labels
bug Something is broken.
Milestone

Comments

@surli
Copy link
Contributor

surli commented Jun 17, 2024

Describe the issue

Same issue as #2980 but for XWiki formats in Weblate. Basically XWiki formats follow Java formats so they should use filename with a underscore for the language locale, and not a dash.
The fix is most probably same as a30a15a but for XWiki formats.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Create a component with type "XWiki Properties" (it does not matter which encoding)
  2. Add a new language "English (United Kingdom)"
  3. Check the created file name - it is {filename}_en-GB.properties

Expected behavior

The file should be created as {filename}_en_GB.properties

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

PyPI module

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

surli added a commit to surli/weblate that referenced this issue Jun 18, 2024
@nijel nijel added this to the 5.6 milestone Jun 18, 2024
@nijel nijel added the bug Something is broken. label Jun 18, 2024
surli added a commit to surli/weblate that referenced this issue Jun 18, 2024
@nijel nijel linked a pull request Jun 18, 2024 that will close this issue
5 tasks
@nijel nijel closed this as completed in 4a0416f Jun 18, 2024
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

1 similar comment
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants