Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore variants in glossary checks #11883

Closed
nijel opened this issue Jun 18, 2024 Discussed in #11726 · 3 comments · Fixed by #11884
Closed

Ignore variants in glossary checks #11883

nijel opened this issue Jun 18, 2024 Discussed in #11726 · 3 comments · Fixed by #11884
Assignees
Labels
bug Something is broken.
Milestone

Comments

@nijel
Copy link
Member

nijel commented Jun 18, 2024

Discussed in #11726

Originally posted by Akemi-Madoka May 28, 2024
How should Variants in the Glossary work with check_glossary in Translation checks?
Example:
"タバナ" => "Tabana"
"タバナ・オミノ" => "Tabana・omino"
"タバナさま" => "Tabana-Sama"
"タババちゃん" => "Tababa-Chan"
"魔王の刃" => "Demon blade"
These four Japanese terms refer to the same person in different contexts, and I think they should fit using the Variants feature.
However, when we created "タバナ" along with the other four Variants in the Glossary, all entries containing any one of the Variants failed to pass check_glossary, no matter which Variant's translation it was translated to.
In summary, a translation of one Variant needs to satisfy all the translations of its Variants to pass check_glossary, which is very confusing for us.
Example: "ちなみにワタシは タバナ。 タバナ・オミノ。"
In this case, the corresponding translation needs to include "Tabana・omino," "Tabana-Sama," "Tababa-Chan," and "Demon blade" to pass check_glossary.

@nijel nijel added the bug Something is broken. label Jun 18, 2024
@nijel nijel added this to the 5.6 milestone Jun 18, 2024
@nijel nijel self-assigned this Jun 18, 2024
@nijel
Copy link
Member Author

nijel commented Jun 18, 2024

The variants should be only displayed in the sidebar and not influence checks or machine translation (if the source string does not match).

nijel added a commit to nijel/weblate that referenced this issue Jun 18, 2024
Only matching source strings should be included, the variants are useful
for display only.

Fixes WeblateOrg#11883
@nijel nijel closed this as completed in 67b2509 Jun 18, 2024
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

1 similar comment
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant