Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual aide of doublespace in edited string #1930

Closed
comradekingu opened this issue Mar 23, 2018 · 8 comments
Closed

Visual aide of doublespace in edited string #1930

comradekingu opened this issue Mar 23, 2018 · 8 comments
Assignees
Labels
enhancement Adding or requesting a new feature. ux Issues related to user experience.
Milestone

Comments

@comradekingu
Copy link
Contributor

comradekingu commented Mar 23, 2018

Above the blue line.
spacecreated
If you make a triplespace, there are three dots.
Regular spaces have no dots.
Makes it visually apparent that there is a doublespace afoot.

@nijel
Copy link
Member

nijel commented Mar 23, 2018

This can be easily done in the the strings we display, there is no support for this in the editor as we use just simple textarea so far...

@nijel nijel added the enhancement Adding or requesting a new feature. label Mar 23, 2018
@nijel
Copy link
Member

nijel commented Mar 23, 2018

I've just implemented it for rendering strings, for the editor it's still open until we use something more complex for entering text.

nijel added a commit that referenced this issue Mar 23, 2018
They are now rendered as dot, while still keeping it as space for copy
and paste.

Issue #1930

Signed-off-by: Michal Čihař <michal@cihar.com>
@comradekingu comradekingu changed the title Visual aide of doublespace Visual aide of doublespace in edited string May 27, 2018
@nijel nijel added the ux Issues related to user experience. label Jan 27, 2020
@nijel
Copy link
Member

nijel commented Jan 28, 2020

From #3417 by @iriman:

Is your feature request related to a problem? Please describe.
Some characters are invisible and could have unwanted effects on the final translation. like directional characters such as LRE, RLE, etc.

Describe the solution you'd like
Making them visible, e.g. by name: <LRE>, <RLE>, etc.

Additional context
I'm specially speacking about these highlighted characters that sometimes need to be inserted in translations:
image

@yarons
Copy link
Contributor

yarons commented Feb 8, 2020

Well if I understand correctly in Pootle it's done via Webfonts and ignoring the directionality charaters altogether leading to a left aligned and reversed text with some black symbols that represent the directionality characters which are non existent characters with a symbol representation of the matching function.

This is how it looks like:
(The editor with the interpreted string)
Screen Shot 2020-02-08 at 13 59 13

(The "raw" version of the same string)
Screen Shot 2020-02-08 at 14 00 04

@nijel
Copy link
Member

nijel commented Feb 8, 2020

My intention is rather to go for some rich editor (for example CodeMirror) and highlight whitespace and special chars there. But frontend is not really my cup of tea....

@yarons
Copy link
Contributor

yarons commented Jul 21, 2020

Well, there's this project by a friend of mine (@tomer) called Pilcrow:
https://tomer.github.io/pilcrow/
This is the source code:
https://github.com/tomer/pilcrow

It could probably be fitted for our needs pretty easily.

@nijel
Copy link
Member

nijel commented Jul 22, 2020

What we need in textarea formatting, while this seems to format non-editable text. Anyway we're now using CodeMirror for some other features, so this should be possible using it as well, it just needs to be implemented ;-).

@nijel nijel added this to the 4.3 milestone Aug 3, 2020
@nijel nijel removed this from the 4.3 milestone Sep 4, 2020
@nijel nijel added this to the 4.4 milestone Sep 15, 2020
@nijel nijel added this to To do in Translation editor via automation Nov 16, 2020
@nijel nijel self-assigned this Nov 19, 2020
@nijel nijel closed this as completed in c69238f Nov 19, 2020
Translation editor automation moved this from To do to Done Nov 19, 2020
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. ux Issues related to user experience.
Projects
Development

No branches or pull requests

3 participants