Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move source language setting to component #4284

Closed
nijel opened this issue Aug 7, 2020 · 2 comments · Fixed by #4458
Closed

Move source language setting to component #4284

nijel opened this issue Aug 7, 2020 · 2 comments · Fixed by #4458
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature.
Milestone
4.3

Comments

@nijel
Copy link
Member

nijel commented Aug 7, 2020

Is your feature request related to a problem? Please describe.
Currently, it appears that the source language can only be defined on the project level. However, for our use case, we need to rather have the source language defined on the component level, so that a project may have various components that contain different source languages.

Describe the solution you'd like
The source language would be moved from the project to component.
@nijel nijel added the enhancement Adding or requesting a new feature. label Aug 7, 2020
@nijel
Copy link
Member Author

nijel commented Aug 7, 2020 •
edited

There are several project wide features which currently rely on consistent source language and need to be addressed:

  • Glossaries do not have language set and inherit it from project settings. Since Global glossaries #3614 the glossaries are independent of a project, so it would be possible to have multiple glossaries for project with different source language.
  • Translation propagation relies on this. When going to component level with this, we need to revisit the way how it is configured, see Translation propagation/distribution #3166
  • Autotranslate operates on project level, it will now have to filter for source language as well
  • Include it in the API, settings and propagated fields in discovery

@nijel nijel mentioned this issue Aug 7, 2020
Open
@nijel nijel mentioned this issue Aug 21, 2020
Closed
@nijel nijel self-assigned this Aug 21, 2020
@nijel nijel mentioned this issue Aug 21, 2020
Merged
4 tasks
kodiakhq bot pushed a commit that referenced this issue Aug 21, 2020
@nijel @kodiakhq
Glossary: Add source language attribute
259ce36 
This makes it behave better when project source language is edited - the
glossary still stays on same source language.

Preparation for #4284
@nijel nijel added this to the 4.3 milestone Sep 3, 2020
nijel added a commit to WeblateOrg/wlc that referenced this issue Sep 7, 2020
@nijel
Support source_language on both project and component level
e548d7e 
Weblate 4.3 will move this attribute.

See WeblateOrg/weblate#4284
@nijel nijel mentioned this issue Sep 7, 2020
Merged
4 tasks
nijel added a commit that referenced this issue Sep 8, 2020
@nijel
Component: Move source language setting from project
3dbd104 
It might be useful to have different source languages within one
project.

Fixes #4284
@github-actions
Copy link

github-actions bot commented Sep 8, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Component: Move source language setting from project
1 participant
@nijel