Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Shortcuts Report and Issues #4841

Closed
kyotarozzz opened this issue Nov 9, 2020 · 3 comments
Closed

Keyboard Shortcuts Report and Issues #4841

kyotarozzz opened this issue Nov 9, 2020 · 3 comments

Comments

@kyotarozzz
Copy link

kyotarozzz commented Nov 9, 2020

All keyboard shortcuts test

I checked #4833, but it's still non-working.
So, I've tried all the keyboard shortcuts for Keyboard shortcuts.
All keyboard shortcuts test of latest Windows 10 and Ubuntu 20.04LTS using chrome and new Edge.
Different OS and browsers, but the result was the same.
The experiment was done in a sandbox project of hosted.weblate.org.
I tried an hour ago.

Non-working shortcut

  • Ctrl M (Shows Automatic suggestions tab)
  • Ctrl M 1 to 9 (Copy the machine translation of given number)
  • Ctrl I 1 to 9 (Ignore one item in the list of failing checks)

Everything else is fine.

CTRL key problem

When the CTRL key is pressed, 'Needs editing' checkbox is deactivated on the translation page.
Also, if you press CTRL+Enter to save a page with the 'Needs editing' checkbox already ON, the page will be saved without 'Needs editing' flag.
Therefore, it cannot be saved with the Needs editing flaged on.
However, once the mouse is clicked in the browser, it works normally.
The click doesn't have to be a form, and the timing doesn't matter.
However, even if you click, if you change the page, it will reset and reproduce the problem.

To Reproduce the problem

Steps to reproduce the behavior:

  1. Use the mouse or CTRL+arrows to navigate to the next translation page.
  2. Display the translation page.
  3. Without clicking your mouse, press CTRL+Y to select 'Needs editing' checkbox.
  4. Use CTRL+J (Nearby strings) or CTRL+Enter (Save current translation).
  5. Deactivate 'Needs editing' checkbox. Or saved without 'Needs editing' flag.

I'm sorry for requesting a fix for the shortcut keys again and again.
The shortcut keys may be difficult to adjust, so it would be nice if you could fix the CTRL key alone.

nijel added a commit that referenced this issue Nov 9, 2020
Now "Ctrl+I Ctrl+1" will work same as "Ctrl+I 1". This avoids needs to
clarify this in the documentation.

Issue #4841
@nijel
Copy link
Member

nijel commented Nov 9, 2020

The experiment was done in a sandbox project of hosted.weblate.org.

The fix from #4833 was not yet deployed there...

All mentioned Ctrl M / I shortcuts do work for me on Chrome and Firefox in my devel environment.

For Ctrl Y, please see #3910

@kyotarozzz
Copy link
Author

Sorry. I guess I spoke too soon. #3910, OK! I'm looking forward to update.

@github-actions
Copy link

The issue you have reported is resolved now. If you don’t feel it’s right, please follow it’s labels to get a clue and take further steps.

  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants