Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl/Cmd+Y doesn't toggle fuzzy flag when textarea has focus #3910

Closed
julen opened this issue May 19, 2020 · 2 comments · Fixed by #4862
Closed

Ctrl/Cmd+Y doesn't toggle fuzzy flag when textarea has focus #3910

julen opened this issue May 19, 2020 · 2 comments · Fixed by #4862
Assignees
@nijel
Labels
bug Something is broken. ux Issues related to user experience.
Projects
Translation editor
Milestone
4.4

Comments

@julen
Copy link
Contributor

julen commented May 19, 2020 •
edited by nijel

Describe the bug
Pressing Cmd+Y for toggling the "Needs editing" flag doesn't work when the editing textarea has focus. When focus is somewhere else, toggling works fine.

I tried this in Mac, but I suspect the behavior is the same in other platforms when using the Ctrl+Y shortcut, because I see testChangeHandler will be invoked for every keypress, including keyboard shortcuts.

To Reproduce
Steps to reproduce the behavior:

  1. Open editor and focus editing textarea
  2. Press Ctrl/Cmd+Y

Expected behavior
"Needs editing" flag is toggled.
@nijel
Copy link
Member

nijel commented May 19, 2020

Confirmed on Linux.

@nijel nijel added bug Something is broken. ux Issues related to user experience. labels May 19, 2020
@nijel nijel mentioned this issue Nov 9, 2020
Closed
@nijel nijel added this to the 4.4 milestone Nov 9, 2020
@nijel nijel self-assigned this Nov 16, 2020
@nijel nijel added this to To do in Translation editor via automation Nov 16, 2020
@nijel nijel moved this from To do to In progress in Translation editor Nov 16, 2020
@nijel nijel mentioned this issue Nov 16, 2020
Merged
5 tasks
Translation editor automation moved this from In progress to Done Nov 19, 2020
nijel added a commit that referenced this issue Nov 19, 2020
@nijel
Translate: Use CodeMirror to edit translations
16a9f87 
* Replace textarea by CodeMirror
* Make the length restriction softer (fixes #3662)
* Improved handling of fuzzy toggler (fixes #3910)
* Remove autosizer dependency as this is now done by CodeMirror
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@nijel nijel mentioned this issue Jan 7, 2021
Merged
10 tasks
nijel added a commit to nijel/weblate that referenced this issue Jan 7, 2021
@nijel
JS: Fix fuzzy flag toggling
7ec9f1e 
Fixes WeblateOrg#3910
kodiakhq bot pushed a commit that referenced this issue Jan 7, 2021
@nijel @kodiakhq
JS: Fix fuzzy flag toggling
3f1f4d0 
Fixes #3910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
bug Something is broken. ux Issues related to user experience.
Projects
Translation editor
  
Done
Milestone
4.4
Development

Successfully merging a pull request may close this issue.

Translate: Use CodeMirror to edit translations
2 participants
@julen @nijel