Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending tasks: Notify responsible translators if source strings modified #5602

Closed
Aikatsui opened this issue Mar 7, 2021 · 8 comments
Closed
Assignees
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature.
Milestone

Comments

@Aikatsui
Copy link

Aikatsui commented Mar 7, 2021

Is your feature request related to a problem? If so, please describe.
This isn't frequent use case but has considerable outcome. most small and large projects maintainers do that randomly then old translation remain months, years without change or some projects try to contact translators privately often. So as solution display modified strings list under pending task tab.

image
https://crowdin.com/project/gitlab-ee/activity_stream (User interface sample only, not the activity_stream feature)

Describe the solution you'd like
#5532 (in user profile)

@nijel
Copy link
Member

nijel commented Mar 7, 2021

With auto-watch in place (see 3dd0a93 and #4866), everybody who translated a string will start watching a project and will get notifications on strings to translate.

@comradekingu
Copy link
Contributor

@Aujatsui In https://hosted.weblate.org/accounts/profile/#notifications__2 there are specific settings for projects the user in question administrates.
If I understand you correctly you want admins to be notified of string-changes and suggestions automatically.

Not sure what the default settings are, maybe you can screenshot them if you haven't changed anything there?

@Aikatsui
Copy link
Author

Aikatsui commented Mar 8, 2021

If I understand you correctly you want admins to be notified of string-changes and suggestions automatically.

No. not it.

This's a example.

  • You're the remmina admin and maintain the project
  • I'm one of translator and have translated 100 strings for specific language
    (once user started to translate then auto adds to watched projects)
    • meanwhile you modify certain(translated) source string e.g. copy --> copy & delete then as mentioned above i am responsible for the recent translation so i need notification about it

In this page https://hosted.weblate.org/accounts/profile/#notifications__1 (watched projects)
Has a setting called "changed string" under translation notification

I couldn't find more details https://docs.weblate.org/en/weblate-4.5.1/user/profile.html?highlight=watched%20projects#notifications

  1. Does it use to notify such modifications?
    (If for it, but it's disabled by default then it can be remove and set set as permanent feature without let users to configure)
  2. I expect this tracked on web-interface within this component Display pending tasks in profile such as new translation requests and other filters #5532 (pending tasks)
    (Above provided UI design sample and task details necessary to remain until anyone address it) sometimes email notifications miss or forget.

@comradekingu
Copy link
Contributor

@Aikatsui
If you contribute to a project, it ends up as a watched project now.

As for what settings are the defaults for
Other projects, Watched projects, Administrated projects it all depends on what the site admin has set up (not me).

The user should always be able to change notifications. If you don't do that you end up with the same problem as sending out too much by default. The e-mails get blocked, and the e-mail account gets blocked because of it.

Since getting immediate notifications and digests per e-mail of string changes already works, I think this can be closed in favour of the "TODO" list on the actual instance #5532

@Aikatsui
Copy link
Author

Aikatsui commented Mar 9, 2021

No. you may misunderstood and this's a separate feature request.

If it exist already as mentioned on (#5602 (comment)) 1-2 then I mean move(merge) this part as new feature design to,
or add this facility to proposed "pending tasks" #5532 component, when such change happened in any contributed project then it appear on responsible translators profiles as a task next they can start to work on it first

@Aikatsui Aikatsui changed the title Notify responsible translators if source strings modified Pending tasks: Notify responsible translators if source strings modified Mar 11, 2021
@nijel nijel added enhancement Adding or requesting a new feature. backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. labels Mar 18, 2021
@github-actions
Copy link

This issue has been added to the backlog. It is not scheduled on the Weblate roadmap, but it eventually might be implemented. In case you need this feature soon, please consider helping or push it by funding the development.

@nijel nijel added this to the 5.4 milestone Dec 22, 2023
@nijel nijel modified the milestones: 5.4, 5.5 Feb 13, 2024
@nijel nijel modified the milestones: 5.5, 5.6 Apr 17, 2024
@nijel nijel modified the milestones: 5.6, 5.7 Jun 17, 2024
@nijel nijel modified the milestones: 5.7, 5.6 Jul 30, 2024
@nijel nijel self-assigned this Jul 30, 2024
@nijel
Copy link
Member

nijel commented Jul 30, 2024

0cef5af adds the notification flow for source changed event. This will be visible on the UI once pending tasks view (#5532) or notifications on website (#6569) are implemented.

@nijel nijel closed this as completed Jul 30, 2024
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature.
Projects
Status: Done
Development

No branches or pull requests

3 participants