Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field last_change date is not updated in some cases #6548

Closed
ZloyChert opened this issue Sep 13, 2021 · 9 comments · Fixed by #10756
Closed

Field last_change date is not updated in some cases #6548

ZloyChert opened this issue Sep 13, 2021 · 9 comments · Fixed by #10756
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@ZloyChert
Copy link

Field last_changed is not updated in following cases with repro steps:

1st case:
Somebody makes any changes to translations in git and pulls/rebase them in component (or any of maintenance functions), last_changed field is not updated.

2nd case:
Somebody createы new component from file in git - last_changed is null. After that, somebody adds new translaiton in that component from weblate UI - last_changed is still null.
Please, see attached screenshot for that case (you can see, that total field changed, but last_changed didn't)
image

I'm using this endpoint: https://docs.weblate.org/en/latest/api.html#get--api-translations-(string-project)-(string-component)-(string-language)-statistics-

Expected behavior
last_changed property is updated with every change.
Also, since there is no property created_date, last_changed can be set after creating.

Weblate version is 4.7.1

@github-actions
Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Sep 24, 2021
@nijel
Copy link
Member

nijel commented Sep 27, 2021

That field currently indicates last change within Weblate, it does not reflect outside changes.

@github-actions github-actions bot removed the wontfix Nobody will work on this. label Sep 28, 2021
@ZloyChert
Copy link
Author

Seems, like there is no reason to expose that field, since it is meaningless for api user and reflects unknown internal processes

@github-actions
Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Oct 10, 2021
@nijel
Copy link
Member

nijel commented Oct 11, 2021

It indicates when the translation was changed in Weblate. It's not meaningless for everybody if you don't have use for this information.

@github-actions github-actions bot removed the wontfix Nobody will work on this. label Oct 12, 2021
@Belorus
Copy link

Belorus commented Oct 12, 2021

4.8.1 same problem.
We update texts via git (do some branch merging) and field is not updated :(

@nijel
Copy link
Member

nijel commented Oct 14, 2021

Field is updated exactly as intended - both last_change and last_author indicate last edit in Weblate. It behaves this way since ever.

See #5726 for related issue.

@github-actions
Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Oct 25, 2021
@nijel nijel added enhancement Adding or requesting a new feature. and removed wontfix Nobody will work on this. labels Jan 11, 2024
@nijel nijel added this to the 5.4 milestone Jan 11, 2024
@nijel nijel self-assigned this Jan 11, 2024
@nijel nijel reopened this Jan 11, 2024
nijel added a commit to nijel/weblate that referenced this issue Jan 11, 2024
It used to track only changes by users inside Weblate, now it reflects
all changes to the translation - including repository updates, comments
or commits.

Fixes WeblateOrg#6548
See WeblateOrg#10512
nijel added a commit to nijel/weblate that referenced this issue Jan 11, 2024
It used to track only changes by users inside Weblate, now it reflects
all changes to the translation - including repository updates, comments
or commits.

Fixes WeblateOrg#6548
See WeblateOrg#10512
nijel added a commit to nijel/weblate that referenced this issue Jan 11, 2024
It used to track only changes by users inside Weblate, now it reflects
all changes to the translation - including repository updates, comments
or commits.

Fixes WeblateOrg#6548
See WeblateOrg#10512
nijel added a commit that referenced this issue Jan 11, 2024
It used to track only changes by users inside Weblate, now it reflects
all changes to the translation - including repository updates, comments
or commits.

Fixes #6548
See #10512
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants