java: String.format() checks wrongly applied to java-format

[ptoscano]

Describe the issue

It seems that weblate tries to apply the checks for a printf-like version of Java format strings (i.e. the ones for String.format() for messages with the java-format format. From what I can see, this does not match the behaviour of GNU gettext:
https://www.gnu.org/software/gettext/manual/html_node/java_002dformat.html

This can be easily checked:

class Test
{
    public static void main(String args[])
    {
        System.out.println(String.format(tr("Hello, %s!"), "format"));
    }
}

and extracting it:

$ xgettext -o - -ktr test-format.java

gives the following (header removed):

#: test-format.java:5
#, java-printf-format
msgid "Hello, %s!"
msgstr ""

I checked the code of weblate at commit f2f333f:

weblate/weblate/checks/format.py

Line 260 in f2f333f

"java-format": (JAVA_MATCH, c_format_is_position_based),

IMHO the above ought to be java-printf-format rather than java-format.

I already tried

• I've read and searched the documentation.
• I've searched for similar issues in this repository.

Steps to reproduce the behavior

No response

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Other

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

[nijel]

When we implemented java-format, Gettext didn't have java-printf-format...

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.