-
-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source changes are not synced as fuzzy in the monolingual po #8036
Comments
For me, the fuzzy flag is written to the file on the force synchronization: #: src-en/data/events_lightspeed.xml:384
#, fuzzy
msgid ""
"data/events_lightspeed.xml$//event[@name=\"ATLAS_MENU\"]/choice[@req=\"SEC "
"SECTOR_DUSKBRINGER_UNIQUE\"]/text"
msgstr "Zum Duskbringer Capitol weiterreisen."
What is intentional is that this state is not written to the file directly - most of the monolingual files do not support his, and thus Weblate doesn't attempt to write the states caused by source string change. |
Weird, here's our environment. Neither the Force sync nor the Files -> Download translation yield that entry marked fuzzy:
I'm curious what made the difference here.
Could you elaborate more? If that was the case then we would have never witnessed them being marked as fuzzy in the first place. But I've got it in my small-scale test (not that repo), and you've got it on this test run as well. Is there a specific condition whether it's enabled or not? Or is there a documentation on this behavior that I can refer to fix it accordingly? |
There is no condition - the needs editing state triggered by source string change is never marked for writing out to the file. The state is kept in Weblate database only. This is because most monolingual formats do not support storing string states. |
Well that's a bit confusing, contradicting both the documentation and the test results. Anyway is there a way that we may query the state programmatically? |
The states changed by Weblate are indeed not covered by the docs at all. Maybe the current behavior is wrong as well, I'm just describing how it currently behaves. Note that I'm testing on 4.14, so it might behave slightly differently than you observe. You can get the state using API: https://docs.weblate.org/en/latest/api.html#get--api-translations-(string-project)-(string-component)-(string-language)-units- |
Got it, thanks. I'll try that API as a workaround for now. |
The issue you have reported is now resolved. If you don’t feel it’s right, please follow its labels to get a clue for further steps.
|
We should be looking at new source as parsed from the file. Issue WeblateOrg#8036
It is expected for formats that supports this to be in sync with Weblate. Fixes WeblateOrg#8036
Let's try if we can easily address this, I've drafted #8047 which should make Weblate commit these flags to the PO files. |
We should be looking at new source as parsed from the file. Issue #8036
It is expected for formats that supports this to be in sync with Weblate. Fixes #8036
Thank you for your report; the issue you have reported has just been fixed.
|
Describe the issue
Our project recently had some changes in the source strings. As it uses monolingual po, Weblate recognized the changes and flagged them as Needs Editing as described here.
After that I tried to make the po files reflect the changes which Weblate had automatically made, by using the Force synchronization command. However after the push it seems the command does nothing to those entries, even if they're marked as
Needs Editing
.I already tried
Steps to reproduce the behavior
The repo is located in https://github.com/ftl-mv-translation/ftl-mv-translation.
locale/data/events_lightspeed.xml/*.po
on the aforementioned branch.Expected behavior
From https://github.com/WeblateOrg/weblate/blob/main/docs/workflows.rst:
After Force synchronization such entries should have been marked as
#, fuzzy
, as they're marked asNeeds Editing
in Weblate.Screenshots
After
Force synchronization
, the entry is dumped as:Notice that there's no
#, fuzzy
thoughNeeds Editing
is checked by Weblate.Exception traceback
No response
How do you run Weblate?
Docker container
Weblate versions
No response
Weblate deploy checks
No response
Additional context
Checks are not available as I have no access on them. The site says the version is 4.12.1.
The text was updated successfully, but these errors were encountered: