Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong press Revert button #8259

Open
2 tasks done
maboroshin opened this issue Oct 23, 2022 · 13 comments
Open
2 tasks done

Wrong press Revert button #8259

maboroshin opened this issue Oct 23, 2022 · 13 comments
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. ux Issues related to user experience.

Comments

@maboroshin
Copy link

maboroshin commented Oct 23, 2022

Describe the issue

View button and Revert button are too close together. According to the CSS code below, the gap is 4 pixels. So, I sometimes press the wrong button.
.btn { padding: 2px 2px; }

The buttons have around 27 pixels.

Also, I'm unaware reverted it because there is no notice. Perhaps others also have done so. To build a cooperative relationship, this mishandling should be prevented.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Login.
  2. This occurs when I am looking at History for all strings or the History tab for each string.
  3. In the screenshot below, I try to press the magnifying glass. But I made a mistake and pressed the arrow button. (Or I just press the arrow button.)

image

Expected behavior

There is no magnifying glass button when displaying each string. It is self-linked.

Solution 1 : Confirm as an important action. This would be essential.

  • Solution 1a : Dialog "Would you like to revert?". It also indicates which string to return to.
  • Or, Solution 1b : Simply copy the text into the translation string field. No automatic saving.

Solution 2: Notify : But, this doesn't prevent a wrong press and auto saving.

  • Notify that "the string has been reverted". Especially in the case of automatic saving. Otherwise, the user may think pressed "View detail" button. So, does not recognize the occurrence of a problem.

Solution 3 : Button design : But, this doesn't prevent a wrong press and auto saving.

  • Widen the gap between View button and Revert button. The gap should be at least 10 pixels. Or/and, If design changes are possible, This button should be at least 36-42 pixels.
  • Or/and, Currently two buttons are placed within one border. Use one border for each button.
  • Or/and, Currently the picture changes color when focused. Add to this, the background color will also change when focused.

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@maboroshin maboroshin changed the title Wrong press of Revert button Wrong press Revert button Oct 23, 2022
@nijel nijel added enhancement Adding or requesting a new feature. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. good first issue Opportunity for newcoming contributors. ux Issues related to user experience. labels Oct 25, 2022
@nijel
Copy link
Member

nijel commented Oct 25, 2022

I'd start with solution 3, that should be pretty easy and not as disturbing as confirmation popup.

@github-actions
Copy link

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@ishikajn8126
Copy link

Hey @nijel @maboroshin , is this issue open to work? I'd like to take this up..

@maboroshin
Copy link
Author

@ishikajn8126 Thanks. This is open! Solution 1 is essential for us.

@ishikajn8126
Copy link

Hey @maboroshin i'm not able to reproduce the behaviour
I went to the history tab but i can see only the view button
image

@maboroshin
Copy link
Author

@ishikajn8126 Please login.

@comradekingu
Copy link
Contributor

@ishikajn8126 I think you are looking at the history of something other than the individual string.
https://hosted.weblate.org/translate/weblate/application/nb_NO/?checksum=76ddb09e484aa37a shows both

@maboroshin
Copy link
Author

@ishikajn8126 : Here's a good sample.

If you press the arrow button by mistake, revert that string.

@ishikajn8126
Copy link

ishikajn8126 commented Oct 28, 2022

thanks @comradekingu @maboroshin , i got it now

@ishikajn8126
Copy link

hey @maboroshin my college exams are commencing, can i get back to this issue after a week ?
also is there any chat forum of weblate?

@maboroshin
Copy link
Author

@ishikajn8126 : We can resume in a week. I will reply if you have any questions. If it is possible for me.

I am not from Weblate. Mr. nijel is Weblate administrator.

@comradekingu
Copy link
Contributor

@ishikajn8126 There is this, and
https://docs.weblate.org/en/latest/index.html#live-chat

Live chat about Weblate is available at Libera.Chat IRC network. The channel name is #weblate. This can be accessed by, for example, https://web.libera.chat/#weblate or an IRC client installed on your computer.

nijel added a commit that referenced this issue Nov 4, 2022
This makes it a bit harder to hit wrong button.

See #8259
@nijel
Copy link
Member

nijel commented Jan 6, 2023

Another issue with these action icons is that they aren't easy to understand (see #8426).

I'm considering including only the obvious actions (for example accept or vote suggestions) and hiding other actions in a dropdown menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. ux Issues related to user experience.
Projects
None yet
Development

No branches or pull requests

4 participants