Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve group project/language selection handling #8629

Closed
nijel opened this issue Jan 18, 2023 · 2 comments · Fixed by #8700
Closed

Improve group project/language selection handling #8629

nijel opened this issue Jan 18, 2023 · 2 comments · Fixed by #8700
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature.
Milestone
4.16

Comments

@nijel
Copy link
Member

nijel commented Jan 18, 2023

Describe the problem

Right now, the project/language selection in the Group model is handled immediately upon save.

This is slowing down the operation on larger Weblate instances, as there can be thousands of public projects and there are hundredths of languages.

Describe the solution you'd like

The .projects and .languages should not be set with anything else than SELECTION_MANUAL.

This will need adjustments in all consumers – they will now have to filter based on the selection in addition to the projects/languages.

Related change was already done in b0d397a for the language authentication.

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

https://sentry.weblate.org/organizations/weblate/performance/summary/?environment=hosted.weblate.org&project=2&query=transaction.duration%3A%3C15m&statsPeriod=24h&transaction=%2Fcreate%2Fproject%2F&unselectedSeries=p100%28%29
@nijel nijel added this to the 4.16 milestone Jan 18, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Jan 29, 2023
@nijel nijel added enhancement Adding or requesting a new feature. and removed wontfix Nobody will work on this. labels Jan 30, 2023
nijel added a commit to nijel/weblate that referenced this issue Jan 30, 2023
@nijel
auth: Use selection for filtering projects
32b7b72 
This is a step towards not building list of all selection based projects
in the memory and using the access control flags instead.

Issue WeblateOrg#8629
@nijel nijel mentioned this issue Jan 30, 2023
Merged
5 tasks
@nijel nijel self-assigned this Jan 30, 2023
nijel added a commit to nijel/weblate that referenced this issue Jan 30, 2023
@nijel
auth: Use selection for filtering projects
8481e44 
This is a step towards not building list of all selection based projects
in the memory and using the access control flags instead.

Issue WeblateOrg#8629
nijel added a commit to nijel/weblate that referenced this issue Jan 30, 2023
@nijel
auth: Use selection for filtering projects
5922ad6 
This is a step towards not building list of all selection based projects
in the memory and using the access control flags instead.

Issue WeblateOrg#8629
nijel added a commit to nijel/weblate that referenced this issue Jan 31, 2023
@nijel
auth: Use selection for filtering projects
8c23ec7 
This is a step towards not building list of all selection based projects
in the memory and using the access control flags instead.

Issue WeblateOrg#8629
nijel added a commit to nijel/weblate that referenced this issue Jan 31, 2023
@nijel
auth: Use selection for filtering projects
305d6be 
- avoid storing relation to all projects/languages in the databse
- use the selection for access control to reduce memory usage

Fixes WeblateOrg#8629
@nijel nijel linked a pull request Jan 31, 2023 that will close this issue
auth: Use selection for filtering projects #8700
Merged
5 tasks
nijel added a commit to nijel/weblate that referenced this issue Feb 1, 2023
@nijel
auth: Use selection for filtering projects
31f7756 
- avoid storing relation to all projects/languages in the databse
- use the selection for access control to reduce memory usage

Fixes WeblateOrg#8629
nijel added a commit that referenced this issue Feb 1, 2023
@nijel
auth: Use selection for filtering projects (#8700)
de41682 
- avoid storing relation to all projects/languages in the database
- use the selection for access control to reduce memory usage

Fixes #8629
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@bebroll bebroll mentioned this issue Mar 22, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
4.16
Development

Successfully merging a pull request may close this issue.

auth: Use selection for filtering projects nijel/weblate
1 participant
@nijel