Preferred language when not logged in

[maboroshin]

Describe the problem

Preferred target language not detected when not logged in.

• List of languages for each component https://hosted.weblate.org/projects/weblate/application/
• Project Languages Tab https://hosted.weblate.org/projects/weblate/#languages

Describe the solution you'd like

Display the browser's display language at the beginning of the language list. Same as when login.

Additional context

"日本語 (Japanese)" is displayed at the bottom of the list due to the rules of Japanese. They have to scroll to the bottom every time. The languages at the bottom in Unicode order have the same problem.

[github-actions]

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

[nijel]

The logic is here:

weblate/weblate/accounts/models.py

Lines 691 to 700 in a58b7f3

	def get_translation_order(self, translation) -> int:
	"""Returns key suitable for ordering languages based on user preferences."""
	language = translation.language
	if language.pk in self.primary_language_ids:
	return 0
	if language.pk in self.secondary_language_ids:
	return 1
	if translation.is_source:
	return 2
	return 3

Adding the current interface language is the easiest path, but that would limit it to only languages in which Weblate is translated. Building on top of Language.objects.get_request_language is probably a more generic approach.

[dankrzeminski32]

Hey @nijel,

I'm starting work on this. What do you mean by "Adding the current interface language"?

If extending on Language.objects.get_request_language, do we catch Language.DoesNotExist and create a new language?

[nijel]

get_request_language already catches DoesNotExist. Creating new languages there is not useful – we would rather not pollute the database with random stuff the user sends in an HTTP header.

[dankrzeminski32]

So if the user is not logged in,

1.) Get language from header using get_request_language and match it to our db record
2.) Prioritize this above all other languages in get_translation_order

Let me know if that sounds right.

[nijel]

Yes, get_translation_order will need to receive request as well to be able to get that information.

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.