Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate notifications #9464

Closed
2 tasks done
ib opened this issue Jun 27, 2023 · 3 comments · Fixed by #9483
Closed
2 tasks done

Duplicate notifications #9464

ib opened this issue Jun 27, 2023 · 3 comments · Fixed by #9483
Assignees
Labels
bug Something is broken.
Milestone

Comments

@ib
Copy link

ib commented Jun 27, 2023

Describe the issue

When a change is made to an already translated string, two notifications are sent, one for the user's "Translated string" notification setting and one for the "Changed string" setting. Both (virtually identical) emails read: "Changed translation" (subject) and "Translation change" (body). (There is only one "Translation changed" entry in the history, but there are two notification emails).

Shouldn't "Translated string" only take effect if the string is newly translated, i.e. was previously untranslated? If not, how to distinguish between a new (i.e. first-time) and a changed translation (notification-wise)?

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Go to user's Settings > Notification.
  2. Enable notification for "Changed string" and "Translated string".
  3. Wait until someone changes a translation.

Expected behavior

When a change is made to an already translated string, only one "Changed string" notification should be sent.

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

Weblate 4.18.1

Weblate deploy checks

No response

Additional context

No response

@nijel nijel self-assigned this Jun 29, 2023
@nijel nijel added the bug Something is broken. label Jun 29, 2023
@nijel nijel added this to the 5.0 milestone Jun 29, 2023
nijel added a commit to nijel/weblate that referenced this issue Jun 29, 2023
When user subscribes both ChangedStringNotificaton and TranslatedStringNotificaton
some events would be delivered twice.

Fixes WeblateOrg#9464
nijel added a commit to nijel/weblate that referenced this issue Jun 29, 2023
When user subscribes both ChangedStringNotificaton and TranslatedStringNotificaton
some events would be delivered twice.

Fixes WeblateOrg#9464
nijel added a commit that referenced this issue Jun 30, 2023
When user subscribes both ChangedStringNotificaton and TranslatedStringNotificaton
some events would be delivered twice.

Fixes #9464
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@ib ib mentioned this issue Jun 30, 2023
2 tasks
@ib

This comment was marked as off-topic.

@nijel

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants