Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic fixup for punctuation spacing #9470

Closed
nijel opened this issue Jun 28, 2023 · 4 comments · Fixed by #10543
Closed

Automatic fixup for punctuation spacing #9470

nijel opened this issue Jun 28, 2023 · 4 comments · Fixed by #10543
Assignees
@nijel
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature.
Milestone
5.3

Comments

@nijel
Copy link
Member

nijel commented Jun 28, 2023

Describe the problem

The Punctuation spacing check accepts breakable space, while the proper solution is to use non-breakable one.

Describe the solution you'd like

Add an automatic fixup which would turn <space><punctuation> in French and Breton to <nb-space><punctuation>.

Describe alternatives you've considered

Make the check more strict and keep this up to the translator.

Screenshots

No response

Additional context

No response
@nijel nijel added enhancement Adding or requesting a new feature. backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. labels Jun 28, 2023
@github-actions
Copy link

This issue has been added to the backlog. It is not scheduled on the Weblate roadmap, but it eventually might be implemented.

In case you need this feature soon, please consider helping or push it by funding the development.

@nijel nijel added this to the 5.3 milestone Nov 22, 2023
@nijel nijel self-assigned this Nov 29, 2023
nijel added a commit to nijel/weblate that referenced this issue Dec 4, 2023
@nijel
fixups: add punctuation spacing fixup
8664e2e 
Fixes WeblateOrg#9470
@nijel nijel mentioned this issue Dec 4, 2023
Merged
5 tasks
nijel added a commit that referenced this issue Dec 4, 2023
@nijel
fixups: add punctuation spacing fixup
0bc96fb 
Fixes #9470
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

nijel added a commit that referenced this issue Jan 5, 2024
@nijel
autofix: make French punctuation spacing only fix exiting space
31040bd 
This was actually requested in #9470 and adding whitespace is more
tricky as there are things like URLs or Markdown where this
should not happen.
@HarmfulBreeze
Copy link

Hello,

Some guides like the Lexique des règles typographiques en usage à l'Imprimerie nationale, often used as a reference in France, specify that there should be a regular non-breaking space before the colon character, but not for other "two-part" characters where a NNBSP should be used instead. Some organizations and media however prefer to use NNBSP with colons.

Are there plans to add a toggle (of sorts) to allow the use of NBSP with colons?

Thanks!
Pierre

@nijel
Copy link
Member Author

nijel commented Mar 20, 2024

Currently, there is no such plan. Please open a separate issue to discuss this.

@HarmfulBreeze HarmfulBreeze mentioned this issue Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
5.3
Development

Successfully merging a pull request may close this issue.

fixups: add punctuation spacing fixup nijel/weblate
2 participants
@nijel @HarmfulBreeze