Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: Add dark theme #9361

Merged
merged 3 commits into from
Jun 9, 2023
Merged

css: Add dark theme #9361

merged 3 commits into from
Jun 9, 2023

Conversation

nijel
Copy link
Member

@nijel nijel commented Jun 7, 2023

Proposed changes

  • add CSS override for dark theme
  • add javascript to toggle that
  • allow to override this in the profile

Fixes #2969

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 4.18 milestone Jun 7, 2023
@nijel nijel marked this pull request as draft June 7, 2023 14:51
@nijel nijel mentioned this pull request Jun 7, 2023
@nijel nijel marked this pull request as ready for review June 8, 2023 12:06
@nijel nijel requested a review from orangesunny as a code owner June 8, 2023 12:06
@nijel nijel force-pushed the dark branch 2 times, most recently from f0d0045 to 567ae70 Compare June 8, 2023 12:25
- add CSS override for dark theme
- add javascript to toggle that
- allow to override this in the profile

Fixes WeblateOrg#2969
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #9361 (84703c5) into main (b645f76) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9361   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files         726      727    +1     
  Lines       54218    54223    +5     
  Branches     8352     8352           
=======================================
+ Hits        49307    49314    +7     
+ Misses       3405     3404    -1     
+ Partials     1506     1505    -1     
Impacted Files Coverage Δ
weblate/accounts/forms.py 90.69% <ø> (ø)
weblate/accounts/tests/test_views.py 100.00% <ø> (ø)
weblate/accounts/migrations/0025_profile_theme.py 100.00% <100.00%> (ø)
weblate/accounts/models.py 88.61% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

@orangesunny orangesunny enabled auto-merge (squash) June 8, 2023 21:39
@orangesunny orangesunny merged commit 7bc74af into WeblateOrg:main Jun 9, 2023
28 checks passed
@nijel nijel deleted the dark branch June 9, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add night theme
2 participants