Additional Mutators #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 2 additional mutators: - HexBinaryMutator which presents an attribute as a hex string but stores it as binary data - UnixTimestampMutator which presents an attribute as a Carbon dateobject but stores it as an int
elliotfehr
reviewed
Sep 9, 2017
src/Mutators/HexBinaryMutator.php
Outdated
| */ | ||
| public function serializeAttribute($value) | ||
| { | ||
| if (!\ctype_xdigit($value)) { |
There was a problem hiding this comment.
We don't need the \ for global functions
| if (!$value instanceof Carbon) { | ||
| throw new MutateException(__METHOD__." expects a Carbon\Carbon value. Received: ". print_r($value, true)); | ||
| } | ||
| return $value->timestamp;; |
elliotfehr
reviewed
Sep 11, 2017
| return [ | ||
| [new \stdClass], | ||
| [0], | ||
| [base64_encode(random_bytes(20))], |
There was a problem hiding this comment.
Can we hardcode our test values + get descriptions for these tests?
| { | ||
| for ($i = 0; $i < 10; $i++) { | ||
| $bytes = random_bytes(20); | ||
| yield [bin2hex($bytes), $bytes]; |
There was a problem hiding this comment.
We should find the hard coded tests cases that will pass/fail instead of a for loop and a random value, otherwise this test should be marked as flaky.
| for ($i = 0; $i < 10; $i++) { | ||
| $t = rand(1, time()); | ||
| $c = Carbon::createFromTimestamp($t); | ||
| yield [$c, $t]; |
There was a problem hiding this comment.
Same with this for loop...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 additional mutators:
HexBinaryMutatorwhich presents an attribute as a hex string but stores it as binary dataUnixTimestampMutatorwhich presents an attribute as a Carbon dateobject but stores it as an int