-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add converter from Pascal VOC to Weed COCO #101
Conversation
A first draft. Not fully tested. Fixes #33
I'm currently getting a red mark here because |
See #105, @hlydecker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the direction you are taking with the utils; it will be good to refactor as many functions as possible out of individual converters into this.
So far this looks good to me, @ElevnLi and I will expand on this with the RDS data.
Thanks for the review, just need to sync this with the current schema to make the ticks green... |
This passes pytest locally... should be good to merge. |
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
===========================================
+ Coverage 31.48% 51.15% +19.66%
===========================================
Files 6 8 +2
Lines 343 477 +134
===========================================
+ Hits 108 244 +136
+ Misses 235 233 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
After updating weedcoco/schema/AgContext.yaml to support EPSG:3857, I could modify Guy's agcontext file and use this to load images into ES:
|
Fixes #33
Replaces #49