Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Model #295

Closed
1 task done
firmai opened this issue Jan 11, 2024 · 3 comments
Closed
1 task done

New Model #295

firmai opened this issue Jan 11, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request new algo Proposing to add a new model/algorithm

Comments

@firmai
Copy link

firmai commented Jan 11, 2024

1. Model description

It would be interesting to add the leader in this benchmark to the imputation pipeline. Btw, nice library :)

https://github.com/thuml/Time-Series-Library/tree/main

2. Check open-source status

  • The model implementation is publicly available

3. Provide useful information for the implementation

No response

@firmai firmai added enhancement New feature or request new algo Proposing to add a new model/algorithm labels Jan 11, 2024
@WenjieDu
Copy link
Owner

Thanks, Derek. Will do. 😎

@WenjieDu
Copy link
Owner

WenjieDu commented Apr 7, 2024

The above PRs tried to add corresponding imputation models into PyPOTS. They take the official code repositories from the paper authors and the implementations from THUML/Time-Series-Library as references. However, I note that different from the SAITS training strategy, the model implementations in THUML/Time-Series-Library do not take the missing mask as a part of the input, while this could make the models confused by observed zeros and missing values filled by zeros. This may degrade the models' imputation performance.

Now that the SAITS training strategy has been validated and now widely adopted in imputation models, we should also apply it to improve the imputation accuracy of the above models.

@WenjieDu
Copy link
Owner

WenjieDu commented Apr 9, 2024

I'm closing this issue. More time-series related models will be adapted into PyPOTS. The SAITS embedding strategy will still be applied to these models for enabling them to work on POTS data.

@WenjieDu WenjieDu closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new algo Proposing to add a new model/algorithm
Projects
None yet
Development

No branches or pull requests

2 participants