Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ETSformer as an imputation model #328

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Add ETSformer as an imputation model #328

merged 3 commits into from
Mar 30, 2024

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. add ETSformer as an imputation model, as suggested in New Model #295;

Before submitting

  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Mar 30, 2024

Pull Request Test Coverage Report for Build 8488788422

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 333 of 344 (96.8%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 82.867%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/etsformer/model.py 67 71 94.37%
pypots/imputation/etsformer/modules/submodules.py 230 237 97.05%
Totals Coverage Status
Change from base Build 8488533632: 0.7%
Covered Lines: 6065
Relevant Lines: 7319

💛 - Coveralls

@WenjieDu WenjieDu merged commit 3c67a12 into dev Mar 30, 2024
6 of 8 checks passed
@WenjieDu WenjieDu deleted the (feat)add_etsformer branch March 30, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants