Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CSDI, updating the docs #210

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Adding CSDI, updating the docs #210

merged 8 commits into from
Oct 11, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Add the model CSDI  #207;
  2. updating the docs;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Oct 11, 2023

Pull Request Test Coverage Report for Build 6484195816

  • 339 of 383 (88.51%) changed or added relevant lines in 12 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 85.233%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/csdi/modules/submodules.py 105 107 98.13%
pypots/imputation/csdi/model.py 56 59 94.92%
pypots/imputation/csdi/data.py 26 41 63.41%
pypots/imputation/csdi/modules/core.py 123 147 83.67%
Files with Coverage Reduction New Missed Lines %
pypots/modules/self_attention.py 1 73.61%
Totals Coverage Status
Change from base Build 6459962947: 0.2%
Covered Lines: 4398
Relevant Lines: 5160

💛 - Coveralls

@WenjieDu WenjieDu merged commit b7b2f25 into main Oct 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants