Fixed conflicts for experimental branch PR #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some conflicts due to master diverging in the meantime
|
Can you add some test cases and a Jupyter notebook for this so I can see the changes? |
|
Dear Jose, You can find a notebook here, but it is the same as the other, cheers Mario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear friends,
thanks a lot for this beautiful package!
I was interested in the experimental branch features that is discussed here in #85 and in #91 but there were some conflicts due to the time that passed between the two branches. I tried to reconcile them and now they could be merged.
I run all the tests and they pass and I was also able to run all the cells in the example notebook. Also the utils.js library now loads correctly in the browser.
I'm not sure if I was able to import all the features but at least it highlight the nodes and show the selection menu.
Once I select the nodes the color of the others stays grey and do not reset.
Best,
Mario