-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental #91
Experimental #91
Conversation
@boludo00 Is this still an issue. No conflicts but I hesitate to merge without an update. |
@boludo00 @jhunpingco Any word when this will be merged into the master? |
@rap10c Not anytime soon! Too busy right now. |
Would like to have neighborhood_highlight=True merged as well |
I really need select_menu and neighborhood_highlight feature. |
…ere were other issues in how the templating, and remote resourcing was being handled that this commit fixes. Updated template directory for the pyvis package to import the template directory as a jinja template environment instead of by file. Previous was imported by filename and didn't allow for include statements as well as not being a template directory. Sources were added without integrety hashes. Updated to import using said integrity checks. Added new argument to Network declration to change how resources are packaged into the end product. This adds remote, in_line, and local as options for building the template. In-line takes raw js files from the lib directory and injects them as inline javascript and can be used for local non-internet access situations, as well when remote files don't wish to be trusted. Remote pulls said sources from remote with integrety checks handled. local will pull the resources from the local lib directory as was being performed before. in_line and remote fixes an issue with pyvis in jupyter-notebook on chrome and safari that caused graphics to error with a blank object due to jupyter denying access due to a CORBS policy due to chrome and safari removing referer on requests to same origin cdns. <meta charset='utf-8'> is a fix for the tom-select pacakge as there is non utf-8 characters implimented. Wrapped tom_select template initialization to check if select_menu is ture as they were being initialized and thus causing errors when this option was set to false. Updated jupyter-notebook to contain options, and examples of the node selection to be able to test changes.
… directory is generated.
Experimental fixes
Hello there! Can we expect this to be merged into master in the near future? |
…nd should allow some additional functionality going foreward.
Add filtering functionality to the network graphs
Resolved merge conflict with master. |
This PR includes various changes to help with organization of bundled dependencies. visjs css and js files are now packaged into the user's working dir by default, or can be set to temp (unstable) by setting
Network(local=False)
.Users can enable a neighborhood highlight feature and select by node ID dropdown menu with
Network(select_menu=True, neighborhood_highlight=True)
.pyvis.mp4
VERY IMPORTANT FOR CHROME ONLY
When restructuring the way these dependencies are handled, the Jupyter Notebook server does NOT like referencing the static JS and CSS in the workspace. This is due to a CORB (Cross Origin Resource Blocking) issue. I don't really know how to implement a fix for this so if someone is more savvy with CORS stuff then take a stab at it. For this reason, use Firefox for Jupyter Notebook Pyvis expirements.