Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlCommand can repeat in a single ST0601 LS. #140

Closed
bradh opened this issue May 21, 2020 · 0 comments · Fixed by #298
Closed

ControlCommand can repeat in a single ST0601 LS. #140

bradh opened this issue May 21, 2020 · 0 comments · Fixed by #298

Comments

@bradh
Copy link
Collaborator

bradh commented May 21, 2020

Describe the bug
ST0601 allows a small number of tags to repeat (see MUL column in Table 1). We don't currently implement any of those though, except for ControlCommand (Tag 115). That will get overwritten in the current parsing approach.

To Reproduce
Steps to reproduce the behavior:
This would require special test data to reproduce. I don't yet have any.

Expected behavior
We'd need to think harder about the change. Possibly a multimap would help.

Screenshots
N/A

Configuration (please complete the following information):
N/A.

Additional context
None at this stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant