st0601: add support for multiple Control Command entries #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #140
Motivation and Context
The Control Command pack can be repeated in a single ST 0601 local set. We don't currently support that, and will overwrite any earlier entries with the last encountered entry. This is currently tracked as #140.
Description
Adds a "holder" class to capture each entry. Its not really clean because of how we serialise out the entries as shown in https://github.com/WestRidgeSystems/jmisb/blob/develop/api/src/main/java/org/jmisb/api/klv/st0601/UasDatalinkMessage.java#L138-L145
I've introduced a special "marker" interface to handle the special case. Currently this is the only class that implements it, but there are more coming (we just don't implement that functionality yet). There are other ways to do this, but this seemed a way to avoid changing existing code everywhere.
How Has This Been Tested?
Unit testing only.
Screenshots (if appropriate):
Types of changes
Checklist: