Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tool for create JSON for content.json file #431

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pratikbutani
Copy link

I have created tool which is helpful to generate JSON by uploading images and other details. Now it will be easy to create JSON for developers. Enjoy!

Copy link
Collaborator

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated your changes to fit better to the rest of the documentation :)
The tool is awesome, thanks for taking the time to build it 👍
It will definitely help other developers to safe time ^^

@MarvinJWendt
Copy link
Collaborator

PS: This resolves #406

Copy link
Author

@pratikbutani pratikbutani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MarvinJWendt for improvement 👍

@pratikbutani pratikbutani changed the title Added tools for create JSON by uploading images Added tool for create JSON for content.json file Mar 1, 2019
@pratikbutani
Copy link
Author

@simonzhexu @amrit-1901 Need to update anything?

@MarvinJWendt
Copy link
Collaborator

@pratikbutani Give it time :)
Somebody will look at it and if you need to make any changes you will get notified 👍

@pratikbutani
Copy link
Author

@MarvinJWendt Here I published article : JSON Creator for WhatsApp Sticker Pack

@simonzhexu
Copy link
Contributor

Hi @pratikbutani and @MarvinJWendt, thank you. Sorry for the delay. Now I am back.
This is great work! I tried it out, it works great!

One thing I want to suggest and you can help, is to add some validation logic.
For example, all the URLs need to start with http or https
the sticker pack folder name/identifier needs to have no space and follow this requirement:

  • identifier: The identifier should be unique and can be alphanumeric: a-z, A-Z, 0-9, and the following characters are also allowed "_", "-", "." and " ". The identifier should be less than 128 characters.

You can also add in your form to let them input the "android_play_store_link" and "ios_app_store_link": "",

I will need to discuss this with some other team members before I can merge this. Give me a few days.

Again, this is great work! Thank you!

@pratikbutani
Copy link
Author

pratikbutani commented Mar 18, 2019

For sure, @simonzhexu I will update as you said.

Thank you so much @Zandor300 for approve pull request. <3

Many thanks to @MarvinJWendt for your motivation. 👍

Hopefully it will be merged soon. Thanks again.

@simonzhexu
Copy link
Contributor

Hi, @pratikbutani , unfortunately, I cannot approve this merge request, as we are not allowed to link to a third party website that may change at any time for the security of developers. I know this may come as a disappointment and I am very sorry.

You are welcome to promote your json generator on your own website and through other channels.

One thing that would work is creating some sort of script that can be run on the repo that can look at the assets folder and create a json file, something like a python script or shell script. The script would be on the repo and we can review it.

@simonzhexu simonzhexu closed this Mar 19, 2019
@MarvinJWendt
Copy link
Collaborator

Hey @simonzhexu, as you mentioned that it would be possible to add a script to the repo:

The tool created by @pratikbutani is actually a single html file (link). Wouldn't it be possible to add that to the stickers repo? The users/developers would have a nice GUI.
There would be some changes that @pratikbutani would have to do tho..
For example, we should remove the donation button then, as I guess that WhatsApp cannot ask for donations. And probably the assets should directly be in the html file, so that it works offline.

But I think this could be a solution, as the file would directly be owned by WhatsApp. I would say that html files provide a better user experience, especially for new developers who don't have much experience with scripting languages as python or shell.

Obviously that would require some changes to the html code, so that it fits with all WhatsApp guidelines.

Just a thought.. :)

@pratikbutani
Copy link
Author

pratikbutani commented Mar 19, 2019

Hi, @pratikbutani , unfortunately, I cannot approve this merge request, as we are not allowed to link to a third party website that may change at any time for the security of developers. I know this may come as a disappointment and I am very sorry.

You are welcome to promote your json generator on your own website and through other channels.

One thing that would work is creating some sort of script that can be run on the repo that can look at the assets folder and create a json file, something like a python script or shell script. The script would be on the repo and we can review it.

Basically I am android developer having good experience to make apps but never tried to make anything in web. This is my first try just because I got the issue to make JSON with all packs. Its tough and time wasting process to make json.

I have just put efforts to make very light and simple tool so developer can use it.

It would be great inspiration for me that I make it successfully.

Thanks for everything.

@pratikbutani
Copy link
Author

Hey @simonzhexu, as you mentioned that it would be possible to add a script to the repo:

The tool created by @pratikbutani is actually a single html file (link). Wouldn't it be possible to add that to the stickers repo? The users/developers would have a nice GUI.
There would be some changes that @pratikbutani would have to do tho..
For example, we should remove the donation button then, as I guess that WhatsApp cannot ask for donations. And probably the assets should directly be in the html file, so that it works offline.

But I think this could be a solution, as the file would directly be owned by WhatsApp. I would say that html files provide a better user experience, especially for new developers who don't have much experience with scripting languages as python or shell.

Obviously that would require some changes to the html code, so that it fits with all WhatsApp guidelines.

Just a thought.. :)

Thank you for your support. If I need to do any changes then I will.

@simonzhexu
Copy link
Contributor

Hey @simonzhexu, as you mentioned that it would be possible to add a script to the repo:

The tool created by @pratikbutani is actually a single html file (link). Wouldn't it be possible to add that to the stickers repo? The users/developers would have a nice GUI.
There would be some changes that @pratikbutani would have to do tho..
For example, we should remove the donation button then, as I guess that WhatsApp cannot ask for donations. And probably the assets should directly be in the html file, so that it works offline.

But I think this could be a solution, as the file would directly be owned by WhatsApp. I would say that html files provide a better user experience, especially for new developers who don't have much experience with scripting languages as python or shell.

Obviously that would require some changes to the html code, so that it fits with all WhatsApp guidelines.

Just a thought.. :)
Hi @pratikbutani , I want to pick up this conversation. Sorry, the thoughts have been lost out of the cracks. I think if we can add the html code into the repo itself and let developers run on their own, ,as @MarvinJWendt suggested. I can merge it in. Are you willing to do some work and make some improvements to the HTML?

@simonzhexu simonzhexu reopened this May 1, 2020
@pratikbutani
Copy link
Author

pratikbutani commented May 1, 2020

Yeah sure, Do let me know what are changes that I have to do? @simonzhexu

@simonzhexu
Copy link
Contributor

Sounds great, I will circle back to you on more details. Really appreciate what you did.

@pratikbutani
Copy link
Author

Sounds great, I will circle back to you on more details. Really appreciate what you did.

Any changes?

@simonzhexu
Copy link
Contributor

I am working with partnerships team to figure out how to work with you. @pratikbutani , please stay tuned.

@pratikbutani
Copy link
Author

I am working with partnerships team to figure out how to work with you. @pratikbutani , please stay tuned.

Hello @simonzhexu Is there any changes that I can do? Any update from your side?

@MarvinJWendt MarvinJWendt mentioned this pull request Jul 8, 2020
@pratikbutani
Copy link
Author

pratikbutani commented Jul 10, 2020

@simonzhexu @MarvinJWendt

Greetings!

What should I do change in JSON Generator to make GIF supported JSON?

@pratikbutani
Copy link
Author

@simonzhexu @MarvinJWendt

Greetings!

What should I do change in JSON Generator to make GIF supported JSON?

@simonzhexu @MarvinJWendt Do let me know what to do?

@pratikbutani
Copy link
Author

I am working with partnerships team to figure out how to work with you. @pratikbutani , please stay tuned.

Do let me know what we can do together?

@pratikbutani
Copy link
Author

@simonzhexu @MarvinJWendt I am eagerly waiting for your response. Do let me know what I need to changes?

@simonzhexu
Copy link
Contributor

Hi @pratikbutani it would be nice to be able to let people run the script inside the repo without going to a website, what I am thinking is, perhaps, we create html page inside this repo and have all the logic inside this repo. User click on the html page inside the repo, and perform the JSON generation, then the html page puts the JSON into the contents.json file.

@simonzhexu
Copy link
Contributor

This is a great project and really love your work. Sorry for the late response.

@pratikbutani
Copy link
Author

Hi @pratikbutani it would be nice to be able to let people run the script inside the repo without going to a website, what I am thinking is, perhaps, we create html page inside this repo and have all the logic inside this repo. User click on the html page inside the repo, and perform the JSON generation, then the html page puts the JSON into the contents.json file.

Yeah that will be also good. Do let me know what to do further?

@simonzhexu
Copy link
Contributor

@pratikbutani , I think the ask from our side is to perform the JSON generation entirely inside this repo without having any code going out to external websites. Do you think it is doable?

@pratikbutani
Copy link
Author

@pratikbutani , I think the ask from our side is to perform the JSON generation entirely inside this repo without having any code going out to external websites. Do you think it is doable?

Yes we can do that also. We can put this HTML file inside the repo and open as web link.

@simonzhexu
Copy link
Contributor

Sounds good. @pratikbutani . Could you update this PR and include all HTML files in the repo? Thank you so much!

@pratikbutani
Copy link
Author

@simonzhexu @BlackGengar Uploaded Zip File. Please take a look.

WAStickerApp-JSON-Generator-master.zip

Do let me know if any changes required.

Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Morkachukzy Morkachukzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pratikbutani
Copy link
Author

Do let me know if I need to change anything here. I will be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants