Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Ubuntu/Mint winehq downloads. #53

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

nomore1007
Copy link
Contributor

added sudo wget -O /etc/apt/keyrings/winehq-archive.key https://dl.winehq.org/wine-builds/winehq.key in place of the current key download.

added sudo wget -O /etc/apt/keyrings/winehq-archive.key https://dl.winehq.org/wine-builds/winehq.key in place of the current key download.
@WheezyE
Copy link
Owner

WheezyE commented Jan 19, 2023

I believe you are correct about this new location for the WineHQ repo's GPG key: It looks like they fixed a bug I reported to WineHQ regarding incorrect pointing to the winehq .sources file. I'll merge this and also update my sed kludge a few lines below.

More info: In the past, there was a bug with WineHQ where the /etc/apt/sources.list.d/winehq-${VERSION_CODENAME}.sources file for any-given version had either Signed-By: /etc/apt/keyrings/winehq-archive.key OR Signed-By: /usr/share/keyrings/winehq-archive.key listed (depending on the version). I put a kludge in the script make the .sources file always point to /usr/share/ but it looks like WineHQ fixed this bug. The official WineHQ documentation at the time also said to put the key file into /usr/share/ , but it looks like that isn't the case anymore. I'll merge this patch and change to kludge to point to /etc/apt/ instead of /usr/share/. It looks like WineHQ put up a new blurb on their Ubunutu page about this very problem here.

@WheezyE
Copy link
Owner

WheezyE commented Jan 19, 2023

Huh, even doing everything correctly, my x64 Linux Mint still fails sometimes for some reason? I'll look into this more later, but but it might just be most stable to have the GPG key saved to both /etc/apt and /usr/share/ for edge-cases where the .sources file points to the wrong place. EDIT: I've decided to stick with the sed method but use /etc/apt/ as the default location for the GPG key since that is what WineHQ seems to be doing.

@WheezyE
Copy link
Owner

WheezyE commented Jan 19, 2023

Oh that's right, I've been experimenting with the debian section of my script on accident instead of the mint section too. I'll update both with this fix.

Thank you for a good catch / for looking out and for looking into this!

@WheezyE WheezyE merged commit 835895b into WheezyE:main Jan 19, 2023
@WheezyE
Copy link
Owner

WheezyE commented Jan 20, 2023

Made sure the non-ARM Debian & Ubuntu installers were updated with this fix too 0b6f04e

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants