Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Turkish, Portuguese, Japanese Locales #82

Merged
merged 4 commits into from
Jun 11, 2023
Merged

Add Turkish, Portuguese, Japanese Locales #82

merged 4 commits into from
Jun 11, 2023

Conversation

kxdrsrt
Copy link
Contributor

@kxdrsrt kxdrsrt commented Jun 10, 2023

  • Added Turkish, Portuguese, Chinese, Japanese localizations
  • Improved German localizations"

IsaacMarovitz
IsaacMarovitz requested changes Jun 10, 2023
View reviewed changes
Copy link
Member

@IsaacMarovitz IsaacMarovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have CN locale, German improvements should be done on Crowdin not here

@kxdrsrt kxdrsrt changed the base branch from main to crowdin June 11, 2023 10:10
@kxdrsrt
Copy link
Contributor Author

kxdrsrt commented Jun 11, 2023 •
edited
Loading

We already have CN locale, German improvements should be done on Crowdin not here

Thank you. I changed the branch to crowdin. What about the other localizations?

@IsaacMarovitz
Copy link
Member

Thank you. I changed the branch to crowdin. What about the other localizations?

I meant remove the CN locale, and apply to German changes to the Crowdin website, and then I can move the new locales to the main branch

@IsaacMarovitz IsaacMarovitz changed the base branch from crowdin to main June 11, 2023 12:37
@IsaacMarovitz IsaacMarovitz changed the title Added Turkish, Portuguese, Chinese, Japanese localizations and improv… Add Turkish, Portuguese, Japanese Locales Jun 11, 2023
@IsaacMarovitz IsaacMarovitz added the locale Update to locale label Jun 11, 2023
@IsaacMarovitz IsaacMarovitz merged commit 266050d into Whisky-App:main Jun 11, 2023
@kxdrsrt kxdrsrt deleted the localization branch June 14, 2023 22:00
ohaiibuzzle pushed a commit to ohaiibuzzle/Whisky that referenced this pull request Jun 20, 2023
@kxdrsrt @IsaacMarovitz
Add Turkish, Portuguese, Japanese Locales (Whisky-App#82)
7fe9944 
* Added Turkish, Portuguese, Chinese, Japanese localizations and improved German localizations

* Remove CN and German changes

* Add to Xcode

---------

Co-authored-by: Peek-a-Chuu <k@s-MacBook-Pro.fritz.box>
Co-authored-by: Isaac Marovitz <isaacryu@icloud.com>
Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacMarovitz IsaacMarovitz IsaacMarovitz approved these changes

Assignees
No one assigned
Labels
locale Update to locale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kxdrsrt @IsaacMarovitz