Merge tests #21
Merge tests #21
Conversation
There was a problem hiding this comment.
Heya @Islast - this looks great - I've added a few requests, the biggest being the rethinking of the logic of write_fixtures. But hopefully not too much work! 😄
TESTS/write_fixtures.py
Outdated
| folder = input('what would you like to name this folder') | ||
| write_fixtures(folder, corrmat=corrmat,net_analysis=net_analysis) | ||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
I don't like that write_fixtures actually calls overwrite_fixtures by default.
Maybe we could change it so that it calls write_fixtures but if the files are already there it asks you if you want to overwrite them?
TESTS/write_fixtures.py
Outdated
| from corrmat_from_regionalmeasures import corrmat_from_regionalmeasures | ||
| corrmat_from_regionalmeasures("EXAMPLE_DATA/PARC_500aparc_thickness_behavmerge.csv", "EXAMPLE_DATA/500.names.txt", corrmat_path, names_308_style=True) | ||
|
|
||
| def Recreate_network_analysis_fixture(folder, corrmat_path): |
There was a problem hiding this comment.
Mega nitpicky request - can we rename Recreate_network_analysis_fixture and Recreate_correlation_matrix_figure to have lowercase rs at the beginning?
TESTS/Regression_tests.py
Outdated
| @@ -0,0 +1,42 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
Super picky - please can Regession_tests be lowercase r?
|
|
||
| if covars_file: | ||
| covars_list = [ line.strip() for line in open(covars_file) ] | ||
| with open(covars_file) as f: | ||
| covars_list = [ line.strip() for line in f ] | ||
| else: | ||
| covars_list = [] | ||
|
|
There was a problem hiding this comment.
This is great! Well caught 🙌
…tion and delete overwrite_fixtures Add documentation
|
Hi @KirstieJane , I've made the changes you suggested 🌺 including add documentation to regression tests #22 |
|
This looks great @Islast - I'm going to merge it in! I realy love 💖💖💖 the documentation in the code, but I was actually meaning a separate markdown file that explains the flow of testing. The use case is that contributors may come along and want to see what tests are done and where they can help, and an overview of the way tests are implemented would be a useful place to start. Not important to add for this pull request tough, merging now! 🎉 |
This was supposed to be a simple 'tests' pull request, but it looks like I forgot to merge some small changes from ooh! June? So I'll leave this open for @KirstieJane to take a look. 🍳