Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add statesync to root.go #117

Merged
merged 10 commits into from
Mar 17, 2023
Merged

add statesync to root.go #117

merged 10 commits into from
Mar 17, 2023

Conversation

faddat
Copy link
Collaborator

@faddat faddat commented Mar 16, 2023

Description and Motivation

This PR will fix state sync for migaloo v1.0.x. Migaloo v1.0.x was missing the configuration needed for
successful state sync in root.go.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly golangci-lint run ./... --fix.

scripts/statesync.bash Fixed Show fixed Hide fixed
scripts/statesync.bash Fixed Show resolved Hide resolved
scripts/statesync.bash Fixed Show fixed Hide fixed
scripts/statesync.bash Fixed Show fixed Hide fixed
@faddat
Copy link
Collaborator Author

faddat commented Mar 17, 2023

@hoangdv2429 some comments, I've fixed the issues:

  • a script that users run shouldn't remove files from their filesystem
  • when debugging this script from your laptop, you probably want to invoke it like:
bash scripts/statesync.bash
  • everything looks good now, can you please:
    • make another PR that removes the notional private endpoint from this script
    • re-verify in that PR
    • make a github action that tests state sync so that we always know that it works

See issue:

#119

@hoangdv2429
Copy link
Contributor

I'll do it now

@faddat
Copy link
Collaborator Author

faddat commented Mar 17, 2023

Excellent thank you

@faddat
Copy link
Collaborator Author

faddat commented Mar 17, 2023

In the meantime I am going to merge this, we can just update the branch afterwards. Please keep in mind that you're next PR should target both versions one and two. Thank you.

@faddat faddat merged commit 5155c0d into release/v1.0.x Mar 17, 2023
@hoank101 hoank101 deleted the fix-statesync branch March 22, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants