[reviewing] patch white whale for 2 newly disclosed bugs #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienn6034
force-pushed
the
faddat/patch-bugs
branch
from
2de8c4e
to
8a5aa9e
Compare
kienn6034
changed the title
kienn6034
requested review from
PolkachuIntern,
Sen-Com,
kerber0x and
0xFable
as code owners
|
I updated logic for the patch to work, and added the encoding scheme for |
|
@faddat please review this? |
kienn6034
changed the title
|
yep
…On Mon, Feb 26, 2024 at 4:46 PM Kien ***@***.***> wrote:
@faddat <https://github.com/faddat> please review this?
—
Reply to this email directly, view it on GitHub
<#329 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWPVCLD56ICTGSAIMYXU3DYVSN3PAVCNFSM6AAAAABDX5SKUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGMYTOOJYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@kienn6034 I approve, but need two reviewers who aren't me to approve it, since I started the PR. 🖖 |
0xFable
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
Related Issues
Checklist:
Update index.md)golangci-lint run ./... --fix.