Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project based filtering for Edited Articles list #1778

Merged
merged 3 commits into from Mar 12, 2018

Conversation

psinghal20
Copy link
Contributor

@psinghal20 psinghal20 commented Mar 10, 2018

Fixes #1686.
This adds reselect based filtering for the Articles Edited list corresponding to projects present. The filter selector is displayed only in the case when there are more than two projects are present which have edited articles. Lodash is used to compute the projects list which is used to generate the options of the filter selector.
ScreenShot
peek 2018-03-11 22-50

@ragesoss
Copy link
Member

@psinghal20 this is my fault for the issue description, but it should actually filter by wiki rather than by project. As in, en.wikipedia.org vs es.wikipedia.org vs wikidata.org.

@psinghal20
Copy link
Contributor Author

Oh, okay. I will make the changes. I think changing this to Wiki won't take much effort.

@psinghal20
Copy link
Contributor Author

@ragesoss Made the changes.
New Screenshot:
peek 2018-03-13 01-38

@ragesoss ragesoss merged commit 6d48c0b into WikiEducationFoundation:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants