Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Salesforce ID Edit commit #1791

Merged
merged 2 commits into from Mar 13, 2018
Merged

Initial Salesforce ID Edit commit #1791

merged 2 commits into from Mar 13, 2018

Conversation

AmitJoki
Copy link
Contributor

@AmitJoki AmitJoki commented Mar 12, 2018 •
edited

Fixes #1539

@AmitJoki AmitJoki mentioned this pull request Mar 12, 2018
Closed
ragesoss
ragesoss reviewed Mar 12, 2018
View reviewed changes
app/assets/javascripts/components/overview/salesforce_link.jsx Outdated
const salesforceId = extractSalesforceId(rawSalesforceId);
ServerActions.linkToSalesforce(this.props.course.id, salesforceId);
},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I think other wording works just fine for updating as well. linkToSalesforce could just be reused with the different button text and I think it'll be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay! Will do.

@ragesoss ragesoss merged commit a66c600 into WikiEducationFoundation:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ragesoss ragesoss ragesoss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmitJoki @ragesoss