remove lodash from bundle #5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use lodash-es everywhere. Since it supports tree shaking, only the functions used are included in the final bundle This also removes the lodash-webpack-plugin which is no longer required. Lodash is still used by eslint, webpack and other development tools, so I've listed it as a dev dependency.
TheTrio
force-pushed
the
removeLodashFromBundle
branch
from
49b0964
to
0f1543a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a single occurrence of
lodashinapp/assets/javascripts/components/students/utils/setOtherEditedArticles.jswhich caused the entire package to be included in the final bundle. This fixes that.Lodash is still used by
eslint, webpack and other development tools so I've listed it as a dev-dependency.I've also updated the command for
yarn analyzeto make sure it analyzes the production bundle and not the development one.